2020-04-19 09:19:49

by Tang Bin

Subject: [PATCH] mfd: asic3: Delete superfluous error message in asic3_probe()

In the function asic3_probe(), when get irq failed, the function
asic3_irq_probe() can called platform_get_irq(), which logs an
error message, so remove redundant message here.

Signed-off-by: Shengju Zhang <[email protected]>
Signed-off-by: Tang Bin <[email protected]>
---
drivers/mfd/asic3.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
index a6bd2134c..7694de3f1 100644
--- a/drivers/mfd/asic3.c
+++ b/drivers/mfd/asic3.c
@@ -987,10 +987,8 @@ static int __init asic3_probe(struct platform_device *pdev)
asic3_write_register(asic, ASIC3_OFFSET(CLOCK, SEL), clksel);

ret = asic3_irq_probe(pdev);
- if (ret < 0) {
- dev_err(asic->dev, "Couldn't probe IRQs\n");
+ if (ret < 0)
goto out_unmap;
- }

asic->gpio.label = "asic3";
asic->gpio.base = pdata->gpio_base;
--
2.20.1.windows.1

2020-04-19 10:57:55

by Markus Elfring

Subject: Re: [PATCH] mfd: asic3: Delete superfluous error message in asic3_probe()

> In the function asic3_probe(), when get irq failed, the function
> asic3_irq_probe() can called platform_get_irq(), which logs an
> error message, so remove redundant message here.

I suggest to improve this change description.

Regards,
Markus