2020-04-15 22:31:24

by Jason Yan

Subject: [PATCH] EDAC: remove defined but not used 'bridge_str'

Fix the following gcc warning:

drivers/edac/amd8131_edac.c:47:21: warning: ‘bridge_str’ defined but not
used [-Wunused-const-variable=]
static char * const bridge_str[] = {
^~~~~~~~~~

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
---
drivers/edac/amd8131_edac.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/drivers/edac/amd8131_edac.c b/drivers/edac/amd8131_edac.c
index 93c82bc17493..169353710982 100644
--- a/drivers/edac/amd8131_edac.c
+++ b/drivers/edac/amd8131_edac.c
@@ -44,14 +44,6 @@ static void edac_pci_write_dword(struct pci_dev *dev, int reg, u32 val32)
" PCI Access Write Error at 0x%x\n", reg);
}

-static char * const bridge_str[] = {
- [NORTH_A] = "NORTH A",
- [NORTH_B] = "NORTH B",
- [SOUTH_A] = "SOUTH A",
- [SOUTH_B] = "SOUTH B",
- [NO_BRIDGE] = "NO BRIDGE",
-};
-
/* Support up to two AMD8131 chipsets on a platform */
static struct amd8131_dev_info amd8131_devices[] = {
{
--
2.21.1

2020-04-16 01:11:49

by Robert Richter

Subject: Re: [PATCH] EDAC: remove defined but not used 'bridge_str'

On 15.04.20 16:50:06, Jason Yan wrote:
> Fix the following gcc warning:
>
> drivers/edac/amd8131_edac.c:47:21: warning: ‘bridge_str’ defined but not
> used [-Wunused-const-variable=]
> static char * const bridge_str[] = {
> ^~~~~~~~~~
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>

Reviewed-by: Robert Richter <[email protected]>

2020-04-24 07:33:50

by Borislav Petkov

Subject: Re: [PATCH] EDAC: remove defined but not used 'bridge_str'

On Wed, Apr 15, 2020 at 04:50:06PM +0800, Jason Yan wrote:
> Fix the following gcc warning:
>
> drivers/edac/amd8131_edac.c:47:21: warning: ‘bridge_str’ defined but not
> used [-Wunused-const-variable=]
> static char * const bridge_str[] = {
> ^~~~~~~~~~
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>
> ---
> drivers/edac/amd8131_edac.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/edac/amd8131_edac.c b/drivers/edac/amd8131_edac.c
> index 93c82bc17493..169353710982 100644
> --- a/drivers/edac/amd8131_edac.c
> +++ b/drivers/edac/amd8131_edac.c
> @@ -44,14 +44,6 @@ static void edac_pci_write_dword(struct pci_dev *dev, int reg, u32 val32)
> " PCI Access Write Error at 0x%x\n", reg);
> }
>
> -static char * const bridge_str[] = {
> - [NORTH_A] = "NORTH A",
> - [NORTH_B] = "NORTH B",
> - [SOUTH_A] = "SOUTH A",
> - [SOUTH_B] = "SOUTH B",
> - [NO_BRIDGE] = "NO BRIDGE",
> -};
> -
> /* Support up to two AMD8131 chipsets on a platform */
> static struct amd8131_dev_info amd8131_devices[] = {
> {
> --

Applied, thanks.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette