2020-04-19 16:50:41

by Dejin Zheng

Subject: [PATCH v1] gpio: fix several typos

Use codespell to fix lots of typos over frontends.

CC: Andy Shevchenko <[email protected]>
Signed-off-by: Dejin Zheng <[email protected]>
---
drivers/gpio/gpio-ftgpio010.c | 2 +-
drivers/gpio/gpio-mm-lantiq.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-ftgpio010.c
index fbddb1662428..4031164780f7 100644
--- a/drivers/gpio/gpio-ftgpio010.c
+++ b/drivers/gpio/gpio-ftgpio010.c
@@ -193,7 +193,7 @@ static int ftgpio_gpio_set_config(struct gpio_chip *gc, unsigned int offset,
if (val == deb_div) {
/*
* The debounce timer happens to already be set to the
- * desireable value, what a coincidence! We can just enable
+ * desirable value, what a coincidence! We can just enable
* debounce on this GPIO line and return. This happens more
* often than you think, for example when all GPIO keys
* on a system are requesting the same debounce interval.
diff --git a/drivers/gpio/gpio-mm-lantiq.c b/drivers/gpio/gpio-mm-lantiq.c
index f460d71b0c92..538e31fe8903 100644
--- a/drivers/gpio/gpio-mm-lantiq.c
+++ b/drivers/gpio/gpio-mm-lantiq.c
@@ -36,7 +36,7 @@ struct ltq_mm {
* @chip: Pointer to our private data structure.
*
* Write the shadow value to the EBU to set the gpios. We need to set the
- * global EBU lock to make sure that PCI/MTD dont break.
+ * global EBU lock to make sure that PCI/MTD don't break.
*/
static void ltq_mm_apply(struct ltq_mm *chip)
{
--
2.25.0

2020-04-24 06:43:51

by Bartosz Golaszewski

Subject: Re: [PATCH v1] gpio: fix several typos

niedz., 19 kwi 2020 o 18:38 Dejin Zheng <[email protected]> napisał(a):
>
> Use codespell to fix lots of typos over frontends.
>
> CC: Andy Shevchenko <[email protected]>
> Signed-off-by: Dejin Zheng <[email protected]>
> ---
> drivers/gpio/gpio-ftgpio010.c | 2 +-
> drivers/gpio/gpio-mm-lantiq.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-ftgpio010.c
> index fbddb1662428..4031164780f7 100644
> --- a/drivers/gpio/gpio-ftgpio010.c
> +++ b/drivers/gpio/gpio-ftgpio010.c
> @@ -193,7 +193,7 @@ static int ftgpio_gpio_set_config(struct gpio_chip *gc, unsigned int offset,
> if (val == deb_div) {
> /*
> * The debounce timer happens to already be set to the
> - * desireable value, what a coincidence! We can just enable
> + * desirable value, what a coincidence! We can just enable
> * debounce on this GPIO line and return. This happens more
> * often than you think, for example when all GPIO keys
> * on a system are requesting the same debounce interval.
> diff --git a/drivers/gpio/gpio-mm-lantiq.c b/drivers/gpio/gpio-mm-lantiq.c
> index f460d71b0c92..538e31fe8903 100644
> --- a/drivers/gpio/gpio-mm-lantiq.c
> +++ b/drivers/gpio/gpio-mm-lantiq.c
> @@ -36,7 +36,7 @@ struct ltq_mm {
> * @chip: Pointer to our private data structure.
> *
> * Write the shadow value to the EBU to set the gpios. We need to set the
> - * global EBU lock to make sure that PCI/MTD dont break.
> + * global EBU lock to make sure that PCI/MTD don't break.
> */
> static void ltq_mm_apply(struct ltq_mm *chip)
> {
> --
> 2.25.0
>

The subject line should be gpio: <name of the driver>: short message

And please split those into patches for each driver.

Bart

2020-04-24 15:15:13

by Dejin Zheng

Subject: Re: [PATCH v1] gpio: fix several typos

On Fri, Apr 24, 2020 at 08:39:04AM +0200, Bartosz Golaszewski wrote:
> niedz., 19 kwi 2020 o 18:38 Dejin Zheng <[email protected]> napisał(a):
> >
> > Use codespell to fix lots of typos over frontends.
> >
> > CC: Andy Shevchenko <[email protected]>
> > Signed-off-by: Dejin Zheng <[email protected]>
> > ---
> > drivers/gpio/gpio-ftgpio010.c | 2 +-
> > drivers/gpio/gpio-mm-lantiq.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-ftgpio010.c
> > index fbddb1662428..4031164780f7 100644
> > --- a/drivers/gpio/gpio-ftgpio010.c
> > +++ b/drivers/gpio/gpio-ftgpio010.c
> > @@ -193,7 +193,7 @@ static int ftgpio_gpio_set_config(struct gpio_chip *gc, unsigned int offset,
> > if (val == deb_div) {
> > /*
> > * The debounce timer happens to already be set to the
> > - * desireable value, what a coincidence! We can just enable
> > + * desirable value, what a coincidence! We can just enable
> > * debounce on this GPIO line and return. This happens more
> > * often than you think, for example when all GPIO keys
> > * on a system are requesting the same debounce interval.
> > diff --git a/drivers/gpio/gpio-mm-lantiq.c b/drivers/gpio/gpio-mm-lantiq.c
> > index f460d71b0c92..538e31fe8903 100644
> > --- a/drivers/gpio/gpio-mm-lantiq.c
> > +++ b/drivers/gpio/gpio-mm-lantiq.c
> > @@ -36,7 +36,7 @@ struct ltq_mm {
> > * @chip: Pointer to our private data structure.
> > *
> > * Write the shadow value to the EBU to set the gpios. We need to set the
> > - * global EBU lock to make sure that PCI/MTD dont break.
> > + * global EBU lock to make sure that PCI/MTD don't break.
> > */
> > static void ltq_mm_apply(struct ltq_mm *chip)
> > {
> > --
> > 2.25.0
> >
>
> The subject line should be gpio: <name of the driver>: short message
>
> And please split those into patches for each driver.
>
Hi Bart:

Thanks for your review, I will send the patch v2 for this change.

BR,
Dejin
> Bart