2020-04-26 03:28:12

by wuxy

Subject: [PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs

From: wuxy <[email protected]>

Winbond has new 1.8V SPI NOR Flash IDs,we need to use the SPI
flash ID in kukui series,this patch can support the new flash IDs.
This patch copied from:https://patchwork.ozlabs.org/patch/1150756/,
The original patch is invalid,so re-submit a new patch for this.

TEST=boot to shell,get the spi information from 'dmesg'.

Signed-off-by: Xingyu Wu <[email protected]>
---
drivers/mtd/spi-nor/winbond.c | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 17deabad57e1..cda4f8847bd6 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -61,6 +61,15 @@ static const struct flash_info winbond_parts[] = {
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
+ { "w25q64jwxxIM", INFO(0xef8017, 0, 64 * 1024, 128,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+ SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
+ { "w25q128jwxxIM", INFO(0xef8018, 0, 64 * 1024, 256,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+ SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
+ { "w25q256jwxxIM", INFO(0xef8019, 0, 64 * 1024, 512,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+ SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
};

/**
--
2.20.1

2020-05-28 00:48:05

by Nicolas Boichat

Subject: Re: [PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs

Hi,

First, you need to cc [email protected], make sure to use
the get_maintainer.pl script to get the cc list (you're cc-ing mm
people here, but you should cc mtd folks instead).

On Sun, Apr 26, 2020 at 11:24 AM <[email protected]> wrote:
>
> From: wuxy <[email protected]>
>
> Winbond has new 1.8V SPI NOR Flash IDs,we need to use the SPI
> flash ID in kukui series,this patch can support the new flash IDs.
> This patch copied from:https://patchwork.ozlabs.org/patch/1150756/,
> The original patch is invalid,so re-submit a new patch for this.

This is historical stuff, and does not belong in the commit message,
please move that below the ---.

Also, since you're merely rebasing/fixing a patch authored by ST Lin,
I'd keep the original author and signed off:
Signed-off-by: ST Lin <[email protected]>

Thanks!

>
> TEST=boot to shell,get the spi information from 'dmesg'.
>
> Signed-off-by: Xingyu Wu <[email protected]>
> ---
> drivers/mtd/spi-nor/winbond.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 17deabad57e1..cda4f8847bd6 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -61,6 +61,15 @@ static const struct flash_info winbond_parts[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> + { "w25q64jwxxIM", INFO(0xef8017, 0, 64 * 1024, 128,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> + { "w25q128jwxxIM", INFO(0xef8018, 0, 64 * 1024, 256,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> + { "w25q256jwxxIM", INFO(0xef8019, 0, 64 * 1024, 512,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> };
>
> /**
> --
> 2.20.1
>
>
>