2020-04-26 09:47:01

by Jason Yan

Subject: [PATCH] staging: rtl8723bs: remove set but not used 'pregistrypriv'

Fix the following gcc warning:

drivers/staging/rtl8723bs/hal/sdio_halinit.c:547:24: warning: variable
‘pregistrypriv’ set but not used [-Wunused-but-set-variable]
struct registry_priv *pregistrypriv;
^~~~~~~~~~~~~

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 7853af53051d..e42d8c18e1ae 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -544,13 +544,9 @@ static void _InitRetryFunction(struct adapter *padapter)

static void HalRxAggr8723BSdio(struct adapter *padapter)
{
- struct registry_priv *pregistrypriv;
u8 valueDMATimeout;
u8 valueDMAPageCount;

-
- pregistrypriv = &padapter->registrypriv;
-
valueDMATimeout = 0x06;
valueDMAPageCount = 0x06;

--
2.21.1

2020-04-27 02:19:22

by Jason Yan

Subject: Re: [PATCH] staging: rtl8723bs: remove set but not used 'pregistrypriv'

Sorry, it has already been fixed by YueHaibing. Please ignore this.

在 2020/4/26 17:43, Jason Yan 写道:
> Fix the following gcc warning:
>
> drivers/staging/rtl8723bs/hal/sdio_halinit.c:547:24: warning: variable
> ‘pregistrypriv’ set but not used [-Wunused-but-set-variable]
> struct registry_priv *pregistrypriv;
> ^~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>
> ---
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> index 7853af53051d..e42d8c18e1ae 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> @@ -544,13 +544,9 @@ static void _InitRetryFunction(struct adapter *padapter)
>
> static void HalRxAggr8723BSdio(struct adapter *padapter)
> {
> - struct registry_priv *pregistrypriv;
> u8 valueDMATimeout;
> u8 valueDMAPageCount;
>
> -
> - pregistrypriv = &padapter->registrypriv;
> -
> valueDMATimeout = 0x06;
> valueDMAPageCount = 0x06;
>
>