2020-04-26 19:18:45

by Christophe JAILLET

[permalink] [raw]

Subject: [PATCH] gpu: host1x: Clean up debugfs in error handling path in 'host1x_probe()'

---

'host1x_debug_init()' must be reverted in an error handling path.

This is already fixed in the remove function since commit 44156eee91ba
("gpu: host1x: Clean up debugfs on removal")

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/gpu/host1x/dev.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c
index 388bcc2889aa..be46554968af 100644
--- a/drivers/gpu/host1x/dev.c
+++ b/drivers/gpu/host1x/dev.c
@@ -435,6 +435,7 @@ static int host1x_probe(struct platform_device *pdev)
return 0;

deinit_intr:
+ host1x_debug_deinit(host);
host1x_intr_deinit(host);
deinit_syncpt:
host1x_syncpt_deinit(host);
--
2.25.1

2020-05-08 10:28:18

by Thierry Reding

[permalink] [raw]

Subject: Re: [PATCH] gpu: host1x: Clean up debugfs in error handling path in 'host1x_probe()'

---

On Sun, Apr 26, 2020 at 09:16:30PM +0200, Christophe JAILLET wrote:
> 'host1x_debug_init()' must be reverted in an error handling path.
>
> This is already fixed in the remove function since commit 44156eee91ba
> ("gpu: host1x: Clean up debugfs on removal")
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> drivers/gpu/host1x/dev.c | 1 +
> 1 file changed, 1 insertion(+)

Applied, thanks.

Thierry

---

Attachments:

(No filename) (445.00 B)
signature.asc (849.00 B)
Download all attachments