2020-04-28 01:08:39

by Jakub Kicinski

[permalink] [raw]
Subject: [PATCH net-next v6 0/5] kselftest: add fixture parameters

Hi!

This set is an attempt to make running tests for different
sets of data easier. The direct motivation is the tls
test which we'd like to run for TLS 1.2 and TLS 1.3,
but currently there is no easy way to invoke the same
tests with different parameters.

Tested all users of kselftest_harness.h.

Dave, would it be possible to take these via net-next?
It seems we're failing to get Shuah's attention.

v2:
- don't run tests by fixture
- don't pass params as an explicit argument

v3:
- go back to the orginal implementation with an extra
parameter, and running by fixture (Kees);
- add LIST_APPEND helper (Kees);
- add a dot between fixture and param name (Kees);
- rename the params to variants (Tim);

v4:
- whitespace fixes.

v5 (Kees):
- move a comment;
- remove a temporary variable;
- reword the commit message on patch 4.

v6:
- resend for net-next.

v1: https://lore.kernel.org/netdev/[email protected]/
v2: https://lore.kernel.org/netdev/[email protected]/
v3: https://lore.kernel.org/netdev/[email protected]/
v4: https://lore.kernel.org/netdev/[email protected]/
v5: https://lore.kernel.org/netdev/[email protected]/

Jakub Kicinski (5):
kselftest: factor out list manipulation to a helper
kselftest: create fixture objects
kselftest: run tests by fixture
kselftest: add fixture variants
selftests: tls: run all tests for TLS 1.2 and TLS 1.3

Documentation/dev-tools/kselftest.rst | 3 +-
tools/testing/selftests/kselftest_harness.h | 234 +++++++++++++++-----
tools/testing/selftests/net/tls.c | 93 ++------
3 files changed, 202 insertions(+), 128 deletions(-)

--
2.25.4


2020-04-28 20:34:05

by David Miller

[permalink] [raw]
Subject: Re: [PATCH net-next v6 0/5] kselftest: add fixture parameters

From: Jakub Kicinski <[email protected]>
Date: Mon, 27 Apr 2020 18:03:46 -0700

> This set is an attempt to make running tests for different
> sets of data easier. The direct motivation is the tls
> test which we'd like to run for TLS 1.2 and TLS 1.3,
> but currently there is no easy way to invoke the same
> tests with different parameters.
>
> Tested all users of kselftest_harness.h.
>
> Dave, would it be possible to take these via net-next?
> It seems we're failing to get Shuah's attention.

Sure, series applied, thanks Jakub.