2020-04-28 01:50:40

by Chen Tao

Subject: [PATCH-next] net: phy: bcm54140: Make a bunch of functions static

Fix the following warning:

drivers/net/phy/bcm54140.c:663:5: warning:
symbol 'bcm54140_did_interrupt' was not declared. Should it be static?
drivers/net/phy/bcm54140.c:672:5: warning:
symbol 'bcm54140_ack_intr' was not declared. Should it be static?
drivers/net/phy/bcm54140.c:684:5: warning:
symbol 'bcm54140_config_intr' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: ChenTao <[email protected]>
---
drivers/net/phy/bcm54140.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/phy/bcm54140.c b/drivers/net/phy/bcm54140.c
index 7341f0126cc4..c009ac2856a5 100644
--- a/drivers/net/phy/bcm54140.c
+++ b/drivers/net/phy/bcm54140.c
@@ -660,7 +660,7 @@ static int bcm54140_config_init(struct phy_device *phydev)
BCM54140_RDB_C_PWR_ISOLATE, 0);
}

-int bcm54140_did_interrupt(struct phy_device *phydev)
+static int bcm54140_did_interrupt(struct phy_device *phydev)
{
int ret;

@@ -669,7 +669,7 @@ int bcm54140_did_interrupt(struct phy_device *phydev)
return (ret < 0) ? 0 : ret;
}

-int bcm54140_ack_intr(struct phy_device *phydev)
+static int bcm54140_ack_intr(struct phy_device *phydev)
{
int reg;

@@ -681,7 +681,7 @@ int bcm54140_ack_intr(struct phy_device *phydev)
return 0;
}

-int bcm54140_config_intr(struct phy_device *phydev)
+static int bcm54140_config_intr(struct phy_device *phydev)
{
struct bcm54140_priv *priv = phydev->priv;
static const u16 port_to_imr_bit[] = {
--
2.22.0

2020-04-28 04:10:04

by Florian Fainelli

Subject: Re: [PATCH-next] net: phy: bcm54140: Make a bunch of functions static

On 4/27/2020 6:48 PM, ChenTao wrote:
> Fix the following warning:
>
> drivers/net/phy/bcm54140.c:663:5: warning:
> symbol 'bcm54140_did_interrupt' was not declared. Should it be static?
> drivers/net/phy/bcm54140.c:672:5: warning:
> symbol 'bcm54140_ack_intr' was not declared. Should it be static?
> drivers/net/phy/bcm54140.c:684:5: warning:
> symbol 'bcm54140_config_intr' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: ChenTao <[email protected]>

Reviewed-by: Florian Fainelli <[email protected]>
--
Florian

2020-04-28 20:56:18

by David Miller

Subject: Re: [PATCH-next] net: phy: bcm54140: Make a bunch of functions static

From: ChenTao <[email protected]>
Date: Tue, 28 Apr 2020 09:48:04 +0800

> Fix the following warning:
>
> drivers/net/phy/bcm54140.c:663:5: warning:
> symbol 'bcm54140_did_interrupt' was not declared. Should it be static?
> drivers/net/phy/bcm54140.c:672:5: warning:
> symbol 'bcm54140_ack_intr' was not declared. Should it be static?
> drivers/net/phy/bcm54140.c:684:5: warning:
> symbol 'bcm54140_config_intr' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: ChenTao <[email protected]>

Applied, thank you.