2020-04-15 15:17:57

by Bjorn Andersson

Subject: [PATCH] phy: qcom: qmp: Add SM8250 UFS PHY

The SM8250 UFS PHY can run off the same initialization sequence as
SM8150, but add the compatible to allow future changes.

Signed-off-by: Bjorn Andersson <[email protected]>
---
Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 5 +++++
drivers/phy/qualcomm/phy-qcom-qmp.c | 3 +++
2 files changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
index 54d6f8d43508..5ff9e7ab6001 100644
--- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
+++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
@@ -19,6 +19,7 @@ Required properties:
"qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on sdm845,
"qcom,sdm845-qmp-ufs-phy" for UFS QMP phy on sdm845,
"qcom,sm8150-qmp-ufs-phy" for UFS QMP phy on sm8150.
+ "qcom,sm8250-qmp-ufs-phy" for UFS QMP phy on sm8250.

- reg:
- index 0: address and length of register set for PHY's common
@@ -69,6 +70,8 @@ Required properties:
"ref", "ref_aux".
For "qcom,sm8150-qmp-ufs-phy" must contain:
"ref", "ref_aux".
+ For "qcom,sm8250-qmp-ufs-phy" must contain:
+ "ref", "ref_aux".

- resets: a list of phandles and reset controller specifier pairs,
one for each entry in reset-names.
@@ -103,6 +106,8 @@ Required properties:
"ufsphy".
For "qcom,sm8150-qmp-ufs-phy": must contain:
"ufsphy".
+ For "qcom,sm8250-qmp-ufs-phy": must contain:
+ "ufsphy".

- vdda-phy-supply: Phandle to a regulator supply to PHY core block.
- vdda-pll-supply: Phandle to 1.8V regulator supply to PHY refclk pll block.
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
index c190406246ab..50cbcdce3680 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
@@ -2536,6 +2536,9 @@ static const struct of_device_id qcom_qmp_phy_of_match_table[] = {
}, {
.compatible = "qcom,sm8150-qmp-ufs-phy",
.data = &sm8150_ufsphy_cfg,
+ }, {
+ .compatible = "qcom,sm8250-qmp-ufs-phy",
+ .data = &sm8150_ufsphy_cfg,
},
{ },
};
--
2.24.0

2020-04-20 21:51:41

by Rob Herring

Subject: Re: [PATCH] phy: qcom: qmp: Add SM8250 UFS PHY

On Tue, 14 Apr 2020 23:07:45 -0700, Bjorn Andersson wrote:
> The SM8250 UFS PHY can run off the same initialization sequence as
> SM8150, but add the compatible to allow future changes.
>
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
> Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 5 +++++
> drivers/phy/qualcomm/phy-qcom-qmp.c | 3 +++
> 2 files changed, 8 insertions(+)
>

Acked-by: Rob Herring <[email protected]>

2020-04-21 06:36:18

by Vinod Koul

Subject: Re: [PATCH] phy: qcom: qmp: Add SM8250 UFS PHY

On 20-04-20, 16:49, Rob Herring wrote:
> On Tue, 14 Apr 2020 23:07:45 -0700, Bjorn Andersson wrote:
> > The SM8250 UFS PHY can run off the same initialization sequence as
> > SM8150, but add the compatible to allow future changes.
> >
> > Signed-off-by: Bjorn Andersson <[email protected]>
> > ---
> > Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 5 +++++
> > drivers/phy/qualcomm/phy-qcom-qmp.c | 3 +++
> > 2 files changed, 8 insertions(+)
> >
>
> Acked-by: Rob Herring <[email protected]>

Reviewed-by: Vinod Koul <[email protected]>
Tested-by: Vinod Koul <[email protected]>

--
~Vinod

2020-04-28 05:06:31

by Vinod Koul

Subject: Re: [PATCH] phy: qcom: qmp: Add SM8250 UFS PHY

On 20-04-20, 16:49, Rob Herring wrote:
> On Tue, 14 Apr 2020 23:07:45 -0700, Bjorn Andersson wrote:
> > The SM8250 UFS PHY can run off the same initialization sequence as
> > SM8150, but add the compatible to allow future changes.
> >
> > Signed-off-by: Bjorn Andersson <[email protected]>
> > ---
> > Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 5 +++++
> > drivers/phy/qualcomm/phy-qcom-qmp.c | 3 +++
> > 2 files changed, 8 insertions(+)
> >
>
> Acked-by: Rob Herring <[email protected]>

Applied, thanks


--
~Vinod