2020-04-28 06:37:20

by Jason Yan

Subject: [PATCH] usb: chipidea: usb2: remove unneeded semicolon

Fix the following coccicheck warning:

drivers/usb/chipidea/ci_hdrc_usb2.c:75:28-29: Unneeded semicolon

Signed-off-by: Jason Yan <[email protected]>
---
drivers/usb/chipidea/ci_hdrc_usb2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c
index 93c864759135..89e1d82d739b 100644
--- a/drivers/usb/chipidea/ci_hdrc_usb2.c
+++ b/drivers/usb/chipidea/ci_hdrc_usb2.c
@@ -72,7 +72,7 @@ static int ci_hdrc_usb2_probe(struct platform_device *pdev)

priv->clk = devm_clk_get_optional(dev, NULL);
if (IS_ERR(priv->clk))
- return PTR_ERR(priv->clk);;
+ return PTR_ERR(priv->clk);

ret = clk_prepare_enable(priv->clk);
if (ret) {
--
2.21.1

2020-04-28 14:05:55

by Michał Mirosław

Subject: Re: [PATCH] usb: chipidea: usb2: remove unneeded semicolon

On Tue, Apr 28, 2020 at 02:33:59PM +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/usb/chipidea/ci_hdrc_usb2.c:75:28-29: Unneeded semicolon
>
> Signed-off-by: Jason Yan <[email protected]>
> ---
> drivers/usb/chipidea/ci_hdrc_usb2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c
> index 93c864759135..89e1d82d739b 100644
> --- a/drivers/usb/chipidea/ci_hdrc_usb2.c
> +++ b/drivers/usb/chipidea/ci_hdrc_usb2.c
> @@ -72,7 +72,7 @@ static int ci_hdrc_usb2_probe(struct platform_device *pdev)
>
> priv->clk = devm_clk_get_optional(dev, NULL);
> if (IS_ERR(priv->clk))
> - return PTR_ERR(priv->clk);;
> + return PTR_ERR(priv->clk);
>
> ret = clk_prepare_enable(priv->clk);
> if (ret) {

Fixes: c2de37b31f17 ("usb: chipidea: usb2: make clock optional")
Reviewed-by: Micha??Miros?aw <[email protected]>

2020-04-29 01:51:16

by Peter Chen

Subject: Re: [PATCH] usb: chipidea: usb2: remove unneeded semicolon

On 20-04-28 16:02:41, Michał Mirosław wrote:
> On Tue, Apr 28, 2020 at 02:33:59PM +0800, Jason Yan wrote:
> > Fix the following coccicheck warning:
> >
> > drivers/usb/chipidea/ci_hdrc_usb2.c:75:28-29: Unneeded semicolon
> >
> > Signed-off-by: Jason Yan <[email protected]>
> > ---
> > drivers/usb/chipidea/ci_hdrc_usb2.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c
> > index 93c864759135..89e1d82d739b 100644
> > --- a/drivers/usb/chipidea/ci_hdrc_usb2.c
> > +++ b/drivers/usb/chipidea/ci_hdrc_usb2.c
> > @@ -72,7 +72,7 @@ static int ci_hdrc_usb2_probe(struct platform_device *pdev)
> >
> > priv->clk = devm_clk_get_optional(dev, NULL);
> > if (IS_ERR(priv->clk))
> > - return PTR_ERR(priv->clk);;
> > + return PTR_ERR(priv->clk);
> >
> > ret = clk_prepare_enable(priv->clk);
> > if (ret) {
>
> Fixes: c2de37b31f17 ("usb: chipidea: usb2: make clock optional")
> Reviewed-by: Michał Mirosław <[email protected]>

Applied, thanks.

--

Thanks,
Peter Chen