2020-04-28 09:07:43

by Zou Wei

Subject: [PATCH -next] tools lib traceevent: Remove unneeded semicolon

Fixes coccicheck warning:

tools/lib/traceevent/kbuffer-parse.c:441:2-3: Unneeded semicolon

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
tools/lib/traceevent/kbuffer-parse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/traceevent/kbuffer-parse.c b/tools/lib/traceevent/kbuffer-parse.c
index b887e74..27f3b07 100644
--- a/tools/lib/traceevent/kbuffer-parse.c
+++ b/tools/lib/traceevent/kbuffer-parse.c
@@ -438,7 +438,7 @@ void *kbuffer_translate_data(int swap, void *data, unsigned int *size)
case KBUFFER_TYPE_TIME_EXTEND:
case KBUFFER_TYPE_TIME_STAMP:
return NULL;
- };
+ }

*size = length;

--
2.6.2

2020-04-28 13:21:00

by Steven Rostedt

Subject: Re: [PATCH -next] tools lib traceevent: Remove unneeded semicolon

On Tue, 28 Apr 2020 17:12:01 +0800
Zou Wei <[email protected]> wrote:

> Fixes coccicheck warning:
>
> tools/lib/traceevent/kbuffer-parse.c:441:2-3: Unneeded semicolon
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
> ---
> tools/lib/traceevent/kbuffer-parse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/traceevent/kbuffer-parse.c b/tools/lib/traceevent/kbuffer-parse.c
> index b887e74..27f3b07 100644
> --- a/tools/lib/traceevent/kbuffer-parse.c
> +++ b/tools/lib/traceevent/kbuffer-parse.c
> @@ -438,7 +438,7 @@ void *kbuffer_translate_data(int swap, void *data, unsigned int *size)
> case KBUFFER_TYPE_TIME_EXTEND:
> case KBUFFER_TYPE_TIME_STAMP:
> return NULL;
> - };
> + }

Acked-by: Steven Rostedt (VMware) <[email protected]>

Arnaldo, can you take this?

Thanks!

-- Steve

>
> *size = length;
>

2020-04-28 17:50:34

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH -next] tools lib traceevent: Remove unneeded semicolon

Em Tue, Apr 28, 2020 at 09:19:15AM -0400, Steven Rostedt escreveu:
> On Tue, 28 Apr 2020 17:12:01 +0800
> Zou Wei <[email protected]> wrote:
>
> > Fixes coccicheck warning:
> >
> > tools/lib/traceevent/kbuffer-parse.c:441:2-3: Unneeded semicolon
> >
> > Reported-by: Hulk Robot <[email protected]>
> > Signed-off-by: Zou Wei <[email protected]>
> > ---
> > tools/lib/traceevent/kbuffer-parse.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/lib/traceevent/kbuffer-parse.c b/tools/lib/traceevent/kbuffer-parse.c
> > index b887e74..27f3b07 100644
> > --- a/tools/lib/traceevent/kbuffer-parse.c
> > +++ b/tools/lib/traceevent/kbuffer-parse.c
> > @@ -438,7 +438,7 @@ void *kbuffer_translate_data(int swap, void *data, unsigned int *size)
> > case KBUFFER_TYPE_TIME_EXTEND:
> > case KBUFFER_TYPE_TIME_STAMP:
> > return NULL;
> > - };
> > + }
>
> Acked-by: Steven Rostedt (VMware) <[email protected]>
>
> Arnaldo, can you take this?

Sure, applied.

> Thanks!
>
> -- Steve
>
> >
> > *size = length;
> >

2020-05-08 13:10:07

by tip-bot2 for Eric Biggers

Subject: [tip: perf/core] libtraceevent: Remove unneeded semicolon

The following commit has been merged into the perf/core branch of tip:

Commit-ID: eebe80c982546ce1041b7dcf3c461406f1e7e88f
Gitweb: https://git.kernel.org/tip/eebe80c982546ce1041b7dcf3c461406f1e7e88f
Author: Zou Wei <[email protected]>
AuthorDate: Tue, 28 Apr 2020 17:12:01 +08:00
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitterDate: Thu, 30 Apr 2020 10:48:32 -03:00

libtraceevent: Remove unneeded semicolon

Fixes coccicheck warning:

tools/lib/traceevent/kbuffer-parse.c:441:2-3: Unneeded semicolon

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
Acked-by: Steven Rostedt (VMware) <[email protected]>
Link: http://lore.kernel.org/lkml/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/lib/traceevent/kbuffer-parse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/traceevent/kbuffer-parse.c b/tools/lib/traceevent/kbuffer-parse.c
index b887e74..27f3b07 100644
--- a/tools/lib/traceevent/kbuffer-parse.c
+++ b/tools/lib/traceevent/kbuffer-parse.c
@@ -438,7 +438,7 @@ void *kbuffer_translate_data(int swap, void *data, unsigned int *size)
case KBUFFER_TYPE_TIME_EXTEND:
case KBUFFER_TYPE_TIME_STAMP:
return NULL;
- };
+ }

*size = length;