On Tue, Apr 28, 2020 at 10:43:18AM +0000, Leslie Hsia(夏邦進_Pegatron) wrote:
> * Author: Leslie Hsia
> * Amplifier driver for TAS5805M, initial the amplifier and set the sound parameter.
> * Signed-off-by: Leslie Hsia <[email protected]<mailto:[email protected]>>
Please follow the patch submission process that is described in
Documentation/process/submitting-patches.rst in the kernel source. Take
a look at other submissions on the list and follow a similar process.
There also appear to be both IIO and ASoC drivers in there which is at
best a bit weird.
Having done a quick scan through your code it doesn't actually seem to
integrate with the subsystem at all (there's no
snd_soc_register_codec())
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
Hi Mark,
Yes, I agree that the code didn’t integrate with ALSA API,
and we only need to initialize i2c registers due to make the amplifier works properly,
and I do find there is already an amplifier driver in /drivers/iio/amplifier/,
that’s why I sent the patch to Jonathan,
I want to put this driver into /drivers/iio/amplifier/,
but he thought that this is an amplifier driver,
and we should put it into /sound/doc/codecs/,
so would you please give me an advice about the driver belongs to which subsystem?
Jonathan, what do you think?
Best Regards,
Leslie
> Mark Brown <[email protected]> 於 2020年4月28日 下午7:30 寫道：
>
> On Tue, Apr 28, 2020 at 10:43:18AM +0000, Leslie Hsia(夏邦進_Pegatron) wrote:
>> * Author: Leslie Hsia
>> * Amplifier driver for TAS5805M, initial the amplifier and set the sound parameter.
>> * Signed-off-by: Leslie Hsia <[email protected]<mailto:[email protected]>>
>
> Please follow the patch submission process that is described in
> Documentation/process/submitting-patches.rst in the kernel source. Take
> a look at other submissions on the list and follow a similar process.
> There also appear to be both IIO and ASoC drivers in there which is at
> best a bit weird.
>
> Having done a quick scan through your code it doesn't actually seem to
> integrate with the subsystem at all (there's no
> snd_soc_register_codec())
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
This e-mail and its attachment may contain information that is confidential or privileged, and are solely for the use of the individual to whom this e-mail is addressed. If you are not the intended recipient or have received it accidentally, please immediately notify the sender by reply e-mail and destroy all copies of this email and its attachment. Please be advised that any unauthorized use, disclosure, distribution or copying of this email or its attachment is strictly prohibited.
本電子郵件及其附件可能含有機密或依法受特殊管制之資訊，僅供本電子郵件之受文者使用。台端如非本電子郵件之受文者或誤收本電子郵件，請立即回覆郵件通知寄件人，並銷毀本電子郵件之所有複本及附件。任何未經授權而使用、揭露、散佈或複製本電子郵件或其附件之行為，皆嚴格禁止 。
On Tue, Apr 28, 2020 at 06:27:45PM +0000, Leslie Hsia(夏邦進_Pegatron) wrote:
Please don't top post, reply in line with needed context. This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.
> but he thought that this is an amplifier driver,
> and we should put it into /sound/doc/codecs/,
> so would you please give me an advice about the driver belongs to which subsystem?
> Jonathan, what do you think?
A quick google suggests that this is an audio amplifier so I'd expect it
to be in the audio subsystem. If it were in IIO it wouldn't work with
most userspace audio software...