2020-04-29 14:14:43

by Jason Yan

Subject: [PATCH] KVM: MIPS: use true,false for bool variable

Fix the following coccicheck warning:

arch/mips/kvm/mips.c:82:1-28: WARNING: Assignment of 0/1 to bool
variable
arch/mips/kvm/mips.c:88:1-28: WARNING: Assignment of 0/1 to bool
variable

Signed-off-by: Jason Yan <[email protected]>
---
arch/mips/kvm/mips.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/kvm/mips.c b/arch/mips/kvm/mips.c
index 9f50ceef9978..44eb36b1dbd8 100644
--- a/arch/mips/kvm/mips.c
+++ b/arch/mips/kvm/mips.c
@@ -79,13 +79,13 @@ bool kvm_trace_guest_mode_change;

int kvm_guest_mode_change_trace_reg(void)
{
- kvm_trace_guest_mode_change = 1;
+ kvm_trace_guest_mode_change = true;
return 0;
}

void kvm_guest_mode_change_trace_unreg(void)
{
- kvm_trace_guest_mode_change = 0;
+ kvm_trace_guest_mode_change = false;
}

/*
--
2.21.1

2020-05-14 07:59:56

by Thomas Bogendoerfer

Subject: Re: [PATCH] KVM: MIPS: use true,false for bool variable

On Wed, Apr 29, 2020 at 10:09:35PM +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> arch/mips/kvm/mips.c:82:1-28: WARNING: Assignment of 0/1 to bool
> variable
> arch/mips/kvm/mips.c:88:1-28: WARNING: Assignment of 0/1 to bool
> variable
>
> Signed-off-by: Jason Yan <[email protected]>
> ---
> arch/mips/kvm/mips.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]