2020-04-30 20:33:25

by Julia Lawall

Subject: [PATCH] dp83640: reverse arguments to list_add_tail

In this code, it appears that phyter_clocks is a list head, based on
the previous list_for_each, and that clock->list is intended to be a
list element, given that it has just been initialized in
dp83640_clock_init. Accordingly, switch the arguments to
list_add_tail, which takes the list head as the second argument.

Fixes: cb646e2b02b27 ("ptp: Added a clock driver for the National Semiconductor PHYTER.")
Signed-off-by: Julia Lawall <[email protected]>

---
Not tested.

drivers/net/phy/dp83640.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
index 415c27310982..ecbd5e0d685c 100644
--- a/drivers/net/phy/dp83640.c
+++ b/drivers/net/phy/dp83640.c
@@ -1120,7 +1120,7 @@ static struct dp83640_clock *dp83640_clock_get_bus(struct mii_bus *bus)
goto out;
}
dp83640_clock_init(clock, bus);
- list_add_tail(&phyter_clocks, &clock->list);
+ list_add_tail(&clock->list, &phyter_clocks);
out:
mutex_unlock(&phyter_clocks_lock);

2020-05-01 00:51:37

by David Miller

Subject: Re: [PATCH] dp83640: reverse arguments to list_add_tail

From: Julia Lawall <[email protected]>
Date: Thu, 30 Apr 2020 21:51:32 +0200

> In this code, it appears that phyter_clocks is a list head, based on
> the previous list_for_each, and that clock->list is intended to be a
> list element, given that it has just been initialized in
> dp83640_clock_init. Accordingly, switch the arguments to
> list_add_tail, which takes the list head as the second argument.
>
> Fixes: cb646e2b02b27 ("ptp: Added a clock driver for the National Semiconductor PHYTER.")
> Signed-off-by: Julia Lawall <[email protected]>

This looks correct to me too.

Applied and queued up for -stable, thanks.