2020-04-30 08:54:54

by Alexandru Ardelean

Subject: [PATCH] iio: remove iio_get_debugfs_dentry() helper

Not used anywhere.
Looks like it was forgotten in iio.h

Signed-off-by: Alexandru Ardelean <[email protected]>
---
include/linux/iio/iio.h | 16 ----------------
1 file changed, 16 deletions(-)

diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
index 38c4ea505394..1a1da52c55cf 100644
--- a/include/linux/iio/iio.h
+++ b/include/linux/iio/iio.h
@@ -696,22 +696,6 @@ static inline bool iio_buffer_enabled(struct iio_dev *indio_dev)
INDIO_BUFFER_SOFTWARE);
}

-/**
- * iio_get_debugfs_dentry() - helper function to get the debugfs_dentry
- * @indio_dev: IIO device structure for device
- **/
-#if defined(CONFIG_DEBUG_FS)
-static inline struct dentry *iio_get_debugfs_dentry(struct iio_dev *indio_dev)
-{
- return indio_dev->debugfs_dentry;
-}
-#else
-static inline struct dentry *iio_get_debugfs_dentry(struct iio_dev *indio_dev)
-{
- return NULL;
-}
-#endif
-
ssize_t iio_format_value(char *buf, unsigned int type, int size, int *vals);

int iio_str_to_fixpoint(const char *str, int fract_mult, int *integer,
--
2.17.1

2020-04-30 09:06:20

by Alexandru Ardelean

Subject: Re: [PATCH] iio: remove iio_get_debugfs_dentry() helper

On Thu, 2020-04-30 at 11:52 +0300, Alexandru Ardelean wrote:
> Not used anywhere.
> Looks like it was forgotten in iio.h
>

Actually, disregard this.
I've found places where 'indio_dev->debugfs_dentry' is accessed directly and
that should have used this instead.

Apologies for the spam.


> Signed-off-by: Alexandru Ardelean <[email protected]>
> ---
> include/linux/iio/iio.h | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index 38c4ea505394..1a1da52c55cf 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -696,22 +696,6 @@ static inline bool iio_buffer_enabled(struct iio_dev
> *indio_dev)
> INDIO_BUFFER_SOFTWARE);
> }
>
> -/**
> - * iio_get_debugfs_dentry() - helper function to get the debugfs_dentry
> - * @indio_dev: IIO device structure for device
> - **/
> -#if defined(CONFIG_DEBUG_FS)
> -static inline struct dentry *iio_get_debugfs_dentry(struct iio_dev
> *indio_dev)
> -{
> - return indio_dev->debugfs_dentry;
> -}
> -#else
> -static inline struct dentry *iio_get_debugfs_dentry(struct iio_dev
> *indio_dev)
> -{
> - return NULL;
> -}
> -#endif
> -
> ssize_t iio_format_value(char *buf, unsigned int type, int size, int *vals);
>
> int iio_str_to_fixpoint(const char *str, int fract_mult, int *integer,