2020-04-30 12:23:20

by Jason Yan

Subject: [PATCH] scsi: qla2xxx: use true,false for need_mpi_reset

Fix the following coccicheck warning:

drivers/scsi/qla2xxx/qla_tmpl.c:1031:6-20: WARNING: Assignment of 0/1 to
bool variable
drivers/scsi/qla2xxx/qla_tmpl.c:1062:3-17: WARNING: Assignment of 0/1 to
bool variable

Signed-off-by: Jason Yan <[email protected]>
---
drivers/scsi/qla2xxx/qla_tmpl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c
index 819c46f31c05..281973b317a8 100644
--- a/drivers/scsi/qla2xxx/qla_tmpl.c
+++ b/drivers/scsi/qla2xxx/qla_tmpl.c
@@ -1028,7 +1028,7 @@ void
qla27xx_mpi_fwdump(scsi_qla_host_t *vha, int hardware_locked)
{
ulong flags = 0;
- bool need_mpi_reset = 1;
+ bool need_mpi_reset = true;

#ifndef __CHECKER__
if (!hardware_locked)
@@ -1059,7 +1059,7 @@ qla27xx_mpi_fwdump(scsi_qla_host_t *vha, int hardware_locked)
"-> fwdt1 fwdump residual=%+ld\n",
fwdt->dump_size - len);
} else {
- need_mpi_reset = 0;
+ need_mpi_reset = false;
}

vha->hw->mpi_fw_dump_len = len;
--
2.21.1

2020-04-30 13:24:07

by Himanshu Madhani

Subject: Re: [PATCH] scsi: qla2xxx: use true,false for need_mpi_reset

On 4/30/20 7:17 AM, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/scsi/qla2xxx/qla_tmpl.c:1031:6-20: WARNING: Assignment of 0/1 to
> bool variable
> drivers/scsi/qla2xxx/qla_tmpl.c:1062:3-17: WARNING: Assignment of 0/1 to
> bool variable
>
> Signed-off-by: Jason Yan <[email protected]>
> ---
> drivers/scsi/qla2xxx/qla_tmpl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c
> index 819c46f31c05..281973b317a8 100644
> --- a/drivers/scsi/qla2xxx/qla_tmpl.c
> +++ b/drivers/scsi/qla2xxx/qla_tmpl.c
> @@ -1028,7 +1028,7 @@ void
> qla27xx_mpi_fwdump(scsi_qla_host_t *vha, int hardware_locked)
> {
> ulong flags = 0;
> - bool need_mpi_reset = 1;
> + bool need_mpi_reset = true;
>
> #ifndef __CHECKER__
> if (!hardware_locked)
> @@ -1059,7 +1059,7 @@ qla27xx_mpi_fwdump(scsi_qla_host_t *vha, int hardware_locked)
> "-> fwdt1 fwdump residual=%+ld\n",
> fwdt->dump_size - len);
> } else {
> - need_mpi_reset = 0;
> + need_mpi_reset = false;
> }
>
> vha->hw->mpi_fw_dump_len = len;
>

Reviewed-by: Himanshu Madhani <[email protected]>

--
Himanshu Madhani
Oracle Linux Engineering

2020-05-08 02:59:37

by Martin K. Petersen

Subject: Re: [PATCH] scsi: qla2xxx: use true,false for need_mpi_reset

On Thu, 30 Apr 2020 20:17:51 +0800, Jason Yan wrote:

> Fix the following coccicheck warning:
>
> drivers/scsi/qla2xxx/qla_tmpl.c:1031:6-20: WARNING: Assignment of 0/1 to
> bool variable
> drivers/scsi/qla2xxx/qla_tmpl.c:1062:3-17: WARNING: Assignment of 0/1 to
> bool variable

Applied to 5.8/scsi-queue, thanks!

[1/1] scsi: qla2xxx: Use true, false for need_mpi_reset
https://git.kernel.org/mkp/scsi/c/bda552a7741a

--
Martin K. Petersen Oracle Linux Engineering