LinuxLists.cc - [PATCH] drivers/iommu: properly export iommu_group_get_for

2020-04-30 12:06:42

Subject: [PATCH] drivers/iommu: properly export iommu_group_get_for_dev

In commit a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to
permit modular drivers") a bunch of iommu symbols were exported, all
with _GPL markings except iommu_group_get_for_dev(). That export should
also be _GPL like the others.

Cc: Will Deacon <[email protected]>
Cc: Joerg Roedel <[email protected]>
Cc: John Garry <[email protected]>
Fixes: a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to permit modular drivers")
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
drivers/iommu/iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 2b471419e26c..1ecbc8788fe7 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -1428,7 +1428,7 @@ struct iommu_group *iommu_group_get_for_dev(struct device *dev)

return group;
}
-EXPORT_SYMBOL(iommu_group_get_for_dev);
+EXPORT_SYMBOL_GPL(iommu_group_get_for_dev);

struct iommu_domain *iommu_group_default_domain(struct iommu_group *group)
{
--
2.26.2

2020-04-30 12:19:55

by Will Deacon

[permalink] [raw]

Subject: Re: [PATCH] drivers/iommu: properly export iommu_group_get_for_dev

On Thu, Apr 30, 2020 at 02:01:20PM +0200, Greg Kroah-Hartman wrote:
> In commit a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to
> permit modular drivers") a bunch of iommu symbols were exported, all
> with _GPL markings except iommu_group_get_for_dev(). That export should
> also be _GPL like the others.
>
> Cc: Will Deacon <[email protected]>
> Cc: Joerg Roedel <[email protected]>
> Cc: John Garry <[email protected]>
> Fixes: a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to permit modular drivers")
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> ---
> drivers/iommu/iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 2b471419e26c..1ecbc8788fe7 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -1428,7 +1428,7 @@ struct iommu_group *iommu_group_get_for_dev(struct device *dev)
>
> return group;
> }
> -EXPORT_SYMBOL(iommu_group_get_for_dev);
> +EXPORT_SYMBOL_GPL(iommu_group_get_for_dev);
>
> struct iommu_domain *iommu_group_default_domain(struct iommu_group *group)
> {

Thanks, not sure how I managed to screw this up in the original patch!

Acked-by: Will Deacon <[email protected]>

Joerg -- can you pick this one up please?

Cheers,

Will

2020-04-30 12:25:49

by Joerg Roedel

[permalink] [raw]

Subject: Re: [PATCH] drivers/iommu: properly export iommu_group_get_for_dev

On Thu, Apr 30, 2020 at 01:17:53PM +0100, Will Deacon wrote:
> Thanks, not sure how I managed to screw this up in the original patch!
>
> Acked-by: Will Deacon <[email protected]>
>
> Joerg -- can you pick this one up please?

Yes, will send it as a fix for 5.7, but note that this function will be
unexported in 5.8.

Regards,

Joerg

2020-05-01 07:11:41

by Will Deacon

[permalink] [raw]

Subject: Re: [PATCH] drivers/iommu: properly export iommu_group_get_for_dev

On Thu, Apr 30, 2020 at 02:23:32PM +0200, Joerg Roedel wrote:
> On Thu, Apr 30, 2020 at 01:17:53PM +0100, Will Deacon wrote:
> > Thanks, not sure how I managed to screw this up in the original patch!
> >
> > Acked-by: Will Deacon <[email protected]>
> >
> > Joerg -- can you pick this one up please?
>
> Yes, will send it as a fix for 5.7, but note that this function will be
> unexported in 5.8.

Thanks, Joerg.

Will

2020-05-01 11:37:39

by Joerg Roedel

[permalink] [raw]