2020-05-01 06:32:11

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the char-misc tree

Hi all,

After merging the char-misc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/crypto/xilinx/zynqmp-aes-gcm.c: In function 'zynqmp_handle_aes_req':
drivers/crypto/xilinx/zynqmp-aes-gcm.c:137:5: warning: 'status' may be used uninitialized in this function [-Wmaybe-uninitialized]
137 | if (status) {
| ^
drivers/crypto/xilinx/zynqmp-aes-gcm.c:87:15: note: 'status' was declared here
87 | unsigned int status;
| ^~~~~~

Introduced by commit

bc86f9c54616 ("firmware: xilinx: Remove eemi ops for aes engine")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2020-05-01 06:58:12

by Greg KH

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the char-misc tree

On Fri, May 01, 2020 at 04:28:06PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the char-misc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/crypto/xilinx/zynqmp-aes-gcm.c: In function 'zynqmp_handle_aes_req':
> drivers/crypto/xilinx/zynqmp-aes-gcm.c:137:5: warning: 'status' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 137 | if (status) {
> | ^
> drivers/crypto/xilinx/zynqmp-aes-gcm.c:87:15: note: 'status' was declared here
> 87 | unsigned int status;
> | ^~~~~~
>
> Introduced by commit
>
> bc86f9c54616 ("firmware: xilinx: Remove eemi ops for aes engine")

Rajan, can you send me a patch to fix this up please?

thanks,

greg k-h

2020-05-01 10:20:04

by Rajan Vaja

[permalink] [raw]
Subject: RE: linux-next: build warning after merge of the char-misc tree

Hi Greg,

Thanks for notifying. I have submitted "[PATCH char-misc-next] crypto: xilinx: Handle AES PM API return status" to fix warning.

Thanks,
Rajan

> -----Original Message-----
> From: Greg KH <[email protected]>
> Sent: Friday, May 1, 2020 12:25 PM
> To: Stephen Rothwell <[email protected]>; Rajan Vaja
> <[email protected]>; Jolly Shah <[email protected]>
> Cc: Arnd Bergmann <[email protected]>; Linux Next Mailing List <linux-
> [email protected]>; Linux Kernel Mailing List <linux-
> [email protected]>
> Subject: Re: linux-next: build warning after merge of the char-misc tree
>
> CAUTION: This message has originated from an External Source. Please use
> proper judgment and caution when opening attachments, clicking links, or
> responding to this email.
>
>
> On Fri, May 01, 2020 at 04:28:06PM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the char-misc tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > drivers/crypto/xilinx/zynqmp-aes-gcm.c: In function
> 'zynqmp_handle_aes_req':
> > drivers/crypto/xilinx/zynqmp-aes-gcm.c:137:5: warning: 'status' may be
> used uninitialized in this function [-Wmaybe-uninitialized]
> > 137 | if (status) {
> > | ^
> > drivers/crypto/xilinx/zynqmp-aes-gcm.c:87:15: note: 'status' was declared
> here
> > 87 | unsigned int status;
> > | ^~~~~~
> >
> > Introduced by commit
> >
> > bc86f9c54616 ("firmware: xilinx: Remove eemi ops for aes engine")
>
> Rajan, can you send me a patch to fix this up please?
>
> thanks,
>
> greg k-h