2020-05-04 01:50:06

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the char-misc tree

Hi all,

After merging the char-misc tree, Friday's linux-next build (arm64
allmodconfig) failed like this:

ERROR: modpost: "zynqmp_pm_fpga_get_status" [drivers/fpga/zynqmp-fpga.ko] undefined!
ERROR: modpost: "zynqmp_pm_fpga_load" [drivers/fpga/zynqmp-fpga.ko] undefined!

Presumably caused by commit

4db8180ffe7c ("firmware: xilinx: Remove eemi ops for fpga related APIs")

Reported-by: "kernelci.org bot" <[email protected]>

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2020-05-04 01:50:43

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the char-misc tree

Hi all,

[Just adding cc]

On Mon, 4 May 2020 11:46:25 +1000 Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the char-misc tree, Friday's linux-next build (arm64
> allmodconfig) failed like this:
>
> ERROR: modpost: "zynqmp_pm_fpga_get_status" [drivers/fpga/zynqmp-fpga.ko] undefined!
> ERROR: modpost: "zynqmp_pm_fpga_load" [drivers/fpga/zynqmp-fpga.ko] undefined!
>
> Presumably caused by commit
>
> 4db8180ffe7c ("firmware: xilinx: Remove eemi ops for fpga related APIs")
>
> Reported-by: "kernelci.org bot" <[email protected]>

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2020-05-04 07:16:42

by Greg KH

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the char-misc tree

On Mon, May 04, 2020 at 11:47:56AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> [Just adding cc]
>
> On Mon, 4 May 2020 11:46:25 +1000 Stephen Rothwell <[email protected]> wrote:
> >
> > Hi all,
> >
> > After merging the char-misc tree, Friday's linux-next build (arm64
> > allmodconfig) failed like this:
> >
> > ERROR: modpost: "zynqmp_pm_fpga_get_status" [drivers/fpga/zynqmp-fpga.ko] undefined!
> > ERROR: modpost: "zynqmp_pm_fpga_load" [drivers/fpga/zynqmp-fpga.ko] undefined!
> >
> > Presumably caused by commit
> >
> > 4db8180ffe7c ("firmware: xilinx: Remove eemi ops for fpga related APIs")
> >
> > Reported-by: "kernelci.org bot" <[email protected]>

Nathan sent me a patch for this on Friday, sorry I missed it. I'll
queue it up now, thanks.

greg k-h

2020-05-04 07:36:17

by Greg KH

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the char-misc tree

On Mon, May 04, 2020 at 07:05:50AM +0000, Rajan Vaja wrote:
> Hi Greg,


A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

> Nathan Chancellor <[email protected]> have already submitted
> patch "[PATCH] firmware: xilinx: Export
> zynqmp_pm_fpga_{get_status,load}". Will you take it directly or should
> I merge this change in my patch series and submit a new series?

I just merged that patch a few minutes ago, no need to do anything.

I will note that this is the 2nd problem in this patch series that was
found. I had to drop this series previously for these same types of
issues, which I thought were fixed this time. I think you all need to
do a bit more build testing on your end when submitting patches please.

thanks,

greg k-h