2020-05-25 22:46:21

by Max Filippov

[permalink] [raw]
Subject: [PATCH] xtensa: fix flush_icache_user_range in noMMU configs

flush_icache_user_range definition for xtensa is placed under
preprocessor condition that is not processed in noMMU configurations,
resulting in the following build errors:

fs/exec.c:1065:3: error: implicit declaration of function
‘flush_icache_user_range’
fs/binfmt_flat.c:857:2: error: implicit declaration of function
‘flush_icache_user_range’

Move definition outside conditional compilation block.

Fixes: 134d96d05d30 ("xtensa: implement flush_icache_user_range")
Signed-off-by: Max Filippov <[email protected]>
---
arch/xtensa/include/asm/cacheflush.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/xtensa/include/asm/cacheflush.h b/arch/xtensa/include/asm/cacheflush.h
index 460e666ad076..cf907e5bf2f2 100644
--- a/arch/xtensa/include/asm/cacheflush.h
+++ b/arch/xtensa/include/asm/cacheflush.h
@@ -107,8 +107,6 @@ void flush_cache_page(struct vm_area_struct*,
#define flush_cache_page local_flush_cache_page
#endif

-#define flush_icache_user_range flush_icache_range
-
#define local_flush_cache_all() \
do { \
__flush_invalidate_dcache_all(); \
@@ -147,6 +145,8 @@ void local_flush_cache_page(struct vm_area_struct *vma,

#endif

+#define flush_icache_user_range flush_icache_range
+
/* Ensure consistency between data and instruction cache. */
#define local_flush_icache_range(start, end) \
do { \
--
2.20.1