2020-06-12 20:06:29

by Aditya Pakki

Subject: [PATCH] test_objagg: Fix potential memory leak in error handling

In case of failure of check_expect_hints_stats(), the resources
allocated by objagg_hints_get should be freed. The patch fixes
this issue.

Signed-off-by: Aditya Pakki <[email protected]>
---
lib/test_objagg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/test_objagg.c b/lib/test_objagg.c
index 72c1abfa154d..da137939a410 100644
--- a/lib/test_objagg.c
+++ b/lib/test_objagg.c
@@ -979,10 +979,10 @@ static int test_hints_case(const struct hints_case *hints_case)
err_world2_obj_get:
for (i--; i >= 0; i--)
world_obj_put(&world2, objagg, hints_case->key_ids[i]);
- objagg_hints_put(hints);
- objagg_destroy(objagg2);
i = hints_case->key_ids_count;
+ objagg_destroy(objagg2);
err_check_expect_hints_stats:
+ objagg_hints_put(hints);
err_hints_get:
err_check_expect_stats:
err_world_obj_get:
--
2.25.1

2020-06-15 20:37:32

by David Miller

Subject: Re: [PATCH] test_objagg: Fix potential memory leak in error handling

From: Aditya Pakki <[email protected]>
Date: Fri, 12 Jun 2020 15:01:54 -0500

> In case of failure of check_expect_hints_stats(), the resources
> allocated by objagg_hints_get should be freed. The patch fixes
> this issue.
>
> Signed-off-by: Aditya Pakki <[email protected]>

Applied.