2020-06-14 03:41:01

by Aditya Pakki

Subject: [PATCH] hwmon: (ina3221) Fix reference count leak in ina3221_write_enable

ina3221_write_enable() calls pm_runtime_get_sync() that increments
the reference counter. In case of failure, decrement the reference
count and return the error.

Signed-off-by: Aditya Pakki <[email protected]>
---
drivers/hwmon/ina3221.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c
index f335d0cb0c77..9a3b46160de1 100644
--- a/drivers/hwmon/ina3221.c
+++ b/drivers/hwmon/ina3221.c
@@ -492,6 +492,7 @@ static int ina3221_write_enable(struct device *dev, int channel, bool enable)
ret = pm_runtime_get_sync(ina->pm_dev);
if (ret < 0) {
dev_err(dev, "Failed to get PM runtime\n");
+ pm_runtime_put_sync(ina->pm_dev);
return ret;
}
}
--
2.25.1

2020-06-14 09:40:41

by Guenter Roeck

Subject: Re: [PATCH] hwmon: (ina3221) Fix reference count leak in ina3221_write_enable

On 6/13/20 8:38 PM, Aditya Pakki wrote:
> ina3221_write_enable() calls pm_runtime_get_sync() that increments
> the reference counter. In case of failure, decrement the reference
> count and return the error.
>
> Signed-off-by: Aditya Pakki <[email protected]>
> ---
> drivers/hwmon/ina3221.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c
> index f335d0cb0c77..9a3b46160de1 100644
> --- a/drivers/hwmon/ina3221.c
> +++ b/drivers/hwmon/ina3221.c
> @@ -492,6 +492,7 @@ static int ina3221_write_enable(struct device *dev, int channel, bool enable)
> ret = pm_runtime_get_sync(ina->pm_dev);
> if (ret < 0) {
> dev_err(dev, "Failed to get PM runtime\n");
> + pm_runtime_put_sync(ina->pm_dev);
> return ret;
> }
> }
>

Looking into other code handling this error, a call to pm_runtime_put_noidle()
may be more appropriate in this situation.

Guenter