2020-06-24 15:16:51

by Alexandru Tachici

Subject: [PATCH v5 7/7] dt-bindings: hwmon: Add bindings for ADM1266

From: Alexandru Tachici <[email protected]>

Add bindings for the Analog Devices ADM1266 sequencer.

Signed-off-by: Alexandru Tachici <[email protected]>
---
.../bindings/hwmon/adi,adm1266.yaml | 56 +++++++++++++++++++
1 file changed, 56 insertions(+)
create mode 100644 Documentation/devicetree/bindings/hwmon/adi,adm1266.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1266.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1266.yaml
new file mode 100644
index 000000000000..76b62be48d56
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/adi,adm1266.yaml
@@ -0,0 +1,56 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/adi,adm1266.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices ADM1266 Cascadable Super Sequencer with Margin
+ Control and Fault Recording
+
+maintainers:
+ - Alexandru Tachici <[email protected]>
+
+description: |
+ Analog Devices ADM1266 Cascadable Super Sequencer with Margin
+ Control and Fault Recording.
+ https://www.analog.com/media/en/technical-documentation/data-sheets/ADM1266.pdf
+
+properties:
+ compatible:
+ enum:
+ - adi,adm1266
+
+ reg:
+ description: |
+ I2C address of slave device.
+ items:
+ minimum: 0x40
+ maximum: 0x4F
+
+ avcc-supply:
+ description: |
+ Phandle to the Avcc power supply.
+
+ adi,master-adm1266:
+ description: |
+ Represents phandle of a master ADM1266 device cascaded through the IDB.
+ $ref: "/schemas/types.yaml#/definitions/phandle"
+
+required:
+ - compatible
+ - reg
+
+examples:
+ - |
+ i2c0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ adm1266@40 {
+ compatible = "adi,adm1266";
+ reg = <0x40>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+ };
+...
--
2.20.1

2020-07-09 22:16:19

by Rob Herring (Arm)

Subject: Re: [PATCH v5 7/7] dt-bindings: hwmon: Add bindings for ADM1266

On Wed, Jun 24, 2020 at 06:17:36PM +0300, [email protected] wrote:
> From: Alexandru Tachici <[email protected]>
>
> Add bindings for the Analog Devices ADM1266 sequencer.
>
> Signed-off-by: Alexandru Tachici <[email protected]>
> ---
> .../bindings/hwmon/adi,adm1266.yaml | 56 +++++++++++++++++++
> 1 file changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/adi,adm1266.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1266.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1266.yaml
> new file mode 100644
> index 000000000000..76b62be48d56
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1266.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/adi,adm1266.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices ADM1266 Cascadable Super Sequencer with Margin
> + Control and Fault Recording
> +
> +maintainers:
> + - Alexandru Tachici <[email protected]>
> +
> +description: |
> + Analog Devices ADM1266 Cascadable Super Sequencer with Margin
> + Control and Fault Recording.
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ADM1266.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - adi,adm1266
> +
> + reg:
> + description: |
> + I2C address of slave device.
> + items:
> + minimum: 0x40
> + maximum: 0x4F
> +
> + avcc-supply:
> + description: |
> + Phandle to the Avcc power supply.
> +
> + adi,master-adm1266:
> + description: |
> + Represents phandle of a master ADM1266 device cascaded through the IDB.
> + $ref: "/schemas/types.yaml#/definitions/phandle"
> +
> +required:
> + - compatible
> + - reg

Add:

additionalProperties: false

> +
> +examples:
> + - |
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + adm1266@40 {
> + compatible = "adi,adm1266";
> + reg = <0x40>;
> + #address-cells = <1>;
> + #size-cells = <0>;

These aren't documented. Do you expect child nodes?

> + };
> + };
> +...
> --
> 2.20.1
>