2020-06-30 22:41:33

by Kangmin Park

[permalink] [raw]
Subject: [PATCH] dt-bindings: mmc: sdhci-sirf

Fix unit address to match the first address specified in the reg
property of the node.

Signed-off-by: Kangmin Park <[email protected]>
---
Documentation/devicetree/bindings/mmc/sdhci-sirf.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mmc/sdhci-sirf.txt b/Documentation/devicetree/bindings/mmc/sdhci-sirf.txt
index dd6ed464bcb8..61185bbfdf9e 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-sirf.txt
+++ b/Documentation/devicetree/bindings/mmc/sdhci-sirf.txt
@@ -11,7 +11,7 @@ Optional properties:

Example:

- sd0: sdhci@56000000 {
+ sd0: sdhci@cd000000 {
compatible = "sirf,prima2-sdhc";
reg = <0xcd000000 0x100000>;
cd-gpios = <&gpio 6 0>;
--
2.26.2


2020-07-06 14:51:52

by Ulf Hansson

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: mmc: sdhci-sirf

On Wed, 1 Jul 2020 at 00:37, Kangmin Park <[email protected]> wrote:
>
> Fix unit address to match the first address specified in the reg
> property of the node.

Rather than fixing legacy DT doc, can you please consider to convert
the doc into the yaml format instead?

Kind regards
Uffe


>
> Signed-off-by: Kangmin Park <[email protected]>
> ---
> Documentation/devicetree/bindings/mmc/sdhci-sirf.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-sirf.txt b/Documentation/devicetree/bindings/mmc/sdhci-sirf.txt
> index dd6ed464bcb8..61185bbfdf9e 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-sirf.txt
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-sirf.txt
> @@ -11,7 +11,7 @@ Optional properties:
>
> Example:
>
> - sd0: sdhci@56000000 {
> + sd0: sdhci@cd000000 {
> compatible = "sirf,prima2-sdhc";
> reg = <0xcd000000 0x100000>;
> cd-gpios = <&gpio 6 0>;
> --
> 2.26.2
>