2020-07-02 14:39:47

by Wei Yongjun

Subject: [PATCH -next] scftorture: Make symbol 'scf_torture_rand' static

Fix sparse build warning:

kernel/scftorture.c:124:1: warning:
symbol '__pcpu_scope_scf_torture_rand' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wei Yongjun <[email protected]>
---
kernel/scftorture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/scftorture.c b/kernel/scftorture.c
index 52750c564404..d63d700ad297 100644
--- a/kernel/scftorture.c
+++ b/kernel/scftorture.c
@@ -121,7 +121,7 @@ static unsigned long scf_sel_totweight;
static atomic_t n_started;
static atomic_t n_errs;

-DEFINE_TORTURE_RANDOM_PERCPU(scf_torture_rand);
+static DEFINE_TORTURE_RANDOM_PERCPU(scf_torture_rand);

// Print torture statistics. Caller must ensure serialization.
static void scf_torture_stats_print(void)

2020-07-02 17:03:38

by Paul E. McKenney

Subject: Re: [PATCH -next] scftorture: Make symbol 'scf_torture_rand' static

On Thu, Jul 02, 2020 at 10:47:00PM +0800, Wei Yongjun wrote:
> Fix sparse build warning:
>
> kernel/scftorture.c:124:1: warning:
> symbol '__pcpu_scope_scf_torture_rand' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Wei Yongjun <[email protected]>

Good catch, applied, thank you!

Due to recent changes, I hand-applied this as shown below. Please
let me know if I messed anything up.

Thanx, Paul

------------------------------------------------------------------------

commit ff9210137b0b8d8f045dd1fd116253ba7686e892
Author: Wei Yongjun <[email protected]>
Date: Thu Jul 2 09:56:50 2020 -0700

scftorture: Make symbol 'scf_torture_rand' static

The sparse tool complains as follows

kernel/scftorture.c:124:1: warning:
symbol '__pcpu_scope_scf_torture_rand' was not declared. Should it be static?

And this per-CPU variable is not used outside of scftorture.c,
so this commit marks it static.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wei Yongjun <[email protected]>
Signed-off-by: Paul E. McKenney <[email protected]>

diff --git a/kernel/scftorture.c b/kernel/scftorture.c
index 52f74f1..a7fea76 100644
--- a/kernel/scftorture.c
+++ b/kernel/scftorture.c
@@ -134,7 +134,7 @@ static atomic_t n_alloc_errs;
static bool scfdone;
static char *bangstr = "";

-DEFINE_TORTURE_RANDOM_PERCPU(scf_torture_rand);
+static DEFINE_TORTURE_RANDOM_PERCPU(scf_torture_rand);

// Print torture statistics. Caller must ensure serialization.
static void scf_torture_stats_print(void)