2020-07-07 14:40:13

by Lee Jones

Subject: [PATCH v2 20/28] ASoC: sti: uniperif: Mark 'uni_tdm_hw' as __maybe_unused

Only 2 of the 3 source files which include this headerfile actually
reference 'uni_tdm_hw'. The other source file 'sti_uniperif.c' sees
as it as being unused. Mark it as __maybe_unused to show that this
behaviour is not only known, it's intentional.

Fixes the following W=1 kernel build warning(s):

sound/soc/sti/uniperif.h:1351:38: warning: ‘uni_tdm_hw’ defined but not used [-Wunused-const-variable=]
1351 | static const struct snd_pcm_hardware uni_tdm_hw = {
| ^~~~~~~~~~

Cc: Arnaud Pouliquen <[email protected]>
Signed-off-by: Lee Jones <[email protected]>
---
sound/soc/sti/uniperif.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sti/uniperif.h b/sound/soc/sti/uniperif.h
index 2dc2da5d458bd..e22d045d5cd99 100644
--- a/sound/soc/sti/uniperif.h
+++ b/sound/soc/sti/uniperif.h
@@ -1348,7 +1348,7 @@ struct sti_uniperiph_data {
struct sti_uniperiph_dai dai_data;
};

-static const struct snd_pcm_hardware uni_tdm_hw = {
+static const struct snd_pcm_hardware __maybe_unused uni_tdm_hw = {
.info = SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER |
SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_MMAP |
SNDRV_PCM_INFO_MMAP_VALID,
--
2.25.1

2020-07-08 13:36:55

by Arnaud POULIQUEN

Subject: Re: [PATCH v2 20/28] ASoC: sti: uniperif: Mark 'uni_tdm_hw' as __maybe_unused

On 7/7/20 4:37 PM, Lee Jones wrote:
> Only 2 of the 3 source files which include this headerfile actually
> reference 'uni_tdm_hw'. The other source file 'sti_uniperif.c' sees
> as it as being unused. Mark it as __maybe_unused to show that this
> behaviour is not only known, it's intentional.
>
> Fixes the following W=1 kernel build warning(s):
>
> sound/soc/sti/uniperif.h:1351:38: warning: ‘uni_tdm_hw’ defined but not used [-Wunused-const-variable=]
> 1351 | static const struct snd_pcm_hardware uni_tdm_hw = {
> | ^~~~~~~~~~
>
> Cc: Arnaud Pouliquen <[email protected]>
> Signed-off-by: Lee Jones <[email protected]>

Acked-by: Arnaud Pouliquen <[email protected]>

Thanks
Arnaud
> ---
> sound/soc/sti/uniperif.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sti/uniperif.h b/sound/soc/sti/uniperif.h
> index 2dc2da5d458bd..e22d045d5cd99 100644
> --- a/sound/soc/sti/uniperif.h
> +++ b/sound/soc/sti/uniperif.h
> @@ -1348,7 +1348,7 @@ struct sti_uniperiph_data {
> struct sti_uniperiph_dai dai_data;
> };
>
> -static const struct snd_pcm_hardware uni_tdm_hw = {
> +static const struct snd_pcm_hardware __maybe_unused uni_tdm_hw = {
> .info = SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER |
> SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_MMAP |
> SNDRV_PCM_INFO_MMAP_VALID,
>