2020-07-21 15:08:08

by Wei Yongjun

Subject: [PATCH -next] mtd: rawnand: pasemi: Make pasemi_device_ready() static

The sparse tool complains as follows:

drivers/mtd/nand/raw/pasemi_nand.c:71:5: warning:
symbol 'pasemi_device_ready' was not declared. Should it be static?

This function is not used outside of pasemi_nand.c, so this commit
marks it static.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/mtd/nand/raw/pasemi_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/pasemi_nand.c b/drivers/mtd/nand/raw/pasemi_nand.c
index d8eca8c3fdcd..81e2e667037e 100644
--- a/drivers/mtd/nand/raw/pasemi_nand.c
+++ b/drivers/mtd/nand/raw/pasemi_nand.c
@@ -68,7 +68,7 @@ static void pasemi_hwcontrol(struct nand_chip *chip, int cmd,
inl(lpcctl);
}

-int pasemi_device_ready(struct nand_chip *chip)
+static int pasemi_device_ready(struct nand_chip *chip)
{
return !!(inl(lpcctl) & LBICTRL_LPCCTL_NR);
}

2020-09-07 07:25:56

by Miquel Raynal

Subject: Re: [PATCH -next] mtd: rawnand: pasemi: Make pasemi_device_ready() static

On Tue, 2020-07-21 at 15:16:57 UTC, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/mtd/nand/raw/pasemi_nand.c:71:5: warning:
> symbol 'pasemi_device_ready' was not declared. Should it be static?
>
> This function is not used outside of pasemi_nand.c, so this commit
> marks it static.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Wei Yongjun <[email protected]>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel