2020-07-21 18:58:22

by André Almeida

Subject: [PATCH 5.7 1/1] fuse: fix weird page warning

From: Miklos Szeredi <[email protected]>

commit a5005c3cda6eeb6b95645e6cc32f58dafeffc976 upstream.

When PageWaiters was added, updating this check was missed.

Reported-by: Nikolaus Rath <[email protected]>
Reported-by: Hugh Dickins <[email protected]>
Fixes: 62906027091f ("mm: add PageWaiters indicating tasks are waiting for a page bit")
Signed-off-by: Miklos Szeredi <[email protected]>
Signed-off-by: André Almeida <[email protected]>
---
fs/fuse/dev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
index 5c155437a455..ec02c3240176 100644
--- a/fs/fuse/dev.c
+++ b/fs/fuse/dev.c
@@ -771,7 +771,8 @@ static int fuse_check_page(struct page *page)
1 << PG_uptodate |
1 << PG_lru |
1 << PG_active |
- 1 << PG_reclaim))) {
+ 1 << PG_reclaim |
+ 1 << PG_waiters))) {
pr_warn("trying to steal weird page\n");
pr_warn(" page=%p index=%li flags=%08lx, count=%i, mapcount=%i, mapping=%p\n", page, page->index, page->flags, page_count(page), page_mapcount(page), page->mapping);
return 1;
--
2.27.0

2020-07-22 20:39:54

by Sasha Levin

Subject: Re: [PATCH 5.7 1/1] fuse: fix weird page warning

On Tue, Jul 21, 2020 at 03:54:59PM -0300, Andr? Almeida wrote:
>From: Miklos Szeredi <[email protected]>
>
>commit a5005c3cda6eeb6b95645e6cc32f58dafeffc976 upstream.
>
>When PageWaiters was added, updating this check was missed.
>
>Reported-by: Nikolaus Rath <[email protected]>
>Reported-by: Hugh Dickins <[email protected]>
>Fixes: 62906027091f ("mm: add PageWaiters indicating tasks are waiting for a page bit")
>Signed-off-by: Miklos Szeredi <[email protected]>
>Signed-off-by: Andr? Almeida <[email protected]>

Queued for 5.7-4.19, thanks!

--
Thanks,
Sasha