2020-08-20 08:53:59

by Guido Günther

[permalink] [raw]
Subject: [PATCH v2 0/4] arm64: dts: imx8mq: Add NWL DSI host controller to Librem 5 Devkit


These patches add the NWL host controller to the imx8mq and make use of it on
the Librem 5 Devkit enabling the built in MIPI DSI LCD panel.

I opted to add imx8mq internal ports and endpoints between nwl and lcdif to the
generic dtsi since those are SOC rather than board specific properties.

Changes from v1
- Add Reviewed-by from Fabio Estevam, thanks!
https://lore.kernel.org/linux-arm-kernel/CAOMZO5DUA5eS8apZPbte0EcSQ4Vwpg6YLK7D0YdjSUy+kdBu8Q@mail.gmail.com/
https://lore.kernel.org/linux-arm-kernel/CAOMZO5ANrd2JCmHyxZ0Sv0WNcU9T-q3MbaeADxbOwf+31MQ4LQ@mail.gmail.com/#t
https://lore.kernel.org/linux-arm-kernel/CAOMZO5Dg5NGpJ0SQkYny04Kv3ky0619J7YwT-0eE1dsK19o1-w@mail.gmail.com/
- As per review comment by Fabio Estevam
Re-sync DRM related defconfig bits. I didn't resyc the whole defconfig since
this is pretty much kernel version dependent.

Guido Günther (4):
arm64: dts: imx8mq: Add NWL MIPI DSI controller
arm64: dts: imx8mq-librem5-devkit: Enable the LCD panel
arm64: defconfig: re-sync DRM related defconfig bits
arm64: defconfig: Enable imx8mq-librem5-devkit display stack

.../dts/freescale/imx8mq-librem5-devkit.dts | 33 +++++++++++++
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 49 +++++++++++++++++++
arch/arm64/configs/defconfig | 6 ++-
3 files changed, 87 insertions(+), 1 deletion(-)

--
2.26.2


2020-08-20 08:54:48

by Guido Günther

[permalink] [raw]
Subject: [PATCH v2 3/4] arm64: defconfig: re-sync DRM related defconfig bits

This moves the CONFIG_DRM_SIMPLE_BRIDGE entry around making further
updates simpler.

Signed-off-by: Guido Günther <[email protected]>
---
arch/arm64/configs/defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index a03cefd587996..21598afdf34fb 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -645,11 +645,11 @@ CONFIG_DRM_MSM=m
CONFIG_DRM_TEGRA=m
CONFIG_DRM_PANEL_LVDS=m
CONFIG_DRM_PANEL_SIMPLE=m
-CONFIG_DRM_SIMPLE_BRIDGE=m
CONFIG_DRM_PANEL_TRULY_NT35597_WQXGA=m
CONFIG_DRM_DISPLAY_CONNECTOR=m
CONFIG_DRM_LONTIUM_LT9611=m
CONFIG_DRM_SII902X=m
+CONFIG_DRM_SIMPLE_BRIDGE=m
CONFIG_DRM_THINE_THC63LVD1024=m
CONFIG_DRM_TI_SN65DSI86=m
CONFIG_DRM_I2C_ADV7511=m
--
2.26.2

2020-08-20 08:55:25

by Guido Günther

[permalink] [raw]
Subject: [PATCH v2 2/4] arm64: dts: imx8mq-librem5-devkit: Enable the LCD panel

Enable LCD panel output by adding nodes for the NWL DSI host controller,
the Rocktech panel and the eLCDIF display controller.

Signed-off-by: Guido Günther <[email protected]>
Reviewed-by: Fabio Estevam <[email protected]>
---
.../dts/freescale/imx8mq-librem5-devkit.dts | 33 +++++++++++++++++++
1 file changed, 33 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
index e7b5c595ceed7..48e22e93a7a74 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
@@ -830,6 +830,39 @@ MX8MQ_IOMUXC_NAND_DATA03_GPIO3_IO9 0x19 /* WWAN_RESET */
};
};

+&lcdif {
+ status = "okay";
+};
+
+&mipi_dsi {
+ status = "okay";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ panel@0 {
+ compatible = "rocktech,jh057n00900";
+ reg = <0>;
+ backlight = <&backlight_dsi>;
+ reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>;
+ iovcc-supply = <&reg_1v8_p>;
+ vcc-supply = <&reg_2v8_p>;
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&mipi_dsi_out>;
+ };
+ };
+ };
+
+ ports {
+ port@1 {
+ reg = <1>;
+ mipi_dsi_out: endpoint {
+ remote-endpoint = <&panel_in>;
+ };
+ };
+ };
+};
+
&pgc_gpu {
power-supply = <&buck3_reg>;
};
--
2.26.2

2020-08-20 14:05:58

by Martin Kepplinger

[permalink] [raw]
Subject: Re: [PATCH v2 2/4] arm64: dts: imx8mq-librem5-devkit: Enable the LCD panel

On 20.08.20 10:50, Guido Günther wrote:
> Enable LCD panel output by adding nodes for the NWL DSI host controller,
> the Rocktech panel and the eLCDIF display controller.
>
> Signed-off-by: Guido Günther <[email protected]>
> Reviewed-by: Fabio Estevam <[email protected]>
> ---
> .../dts/freescale/imx8mq-librem5-devkit.dts | 33 +++++++++++++++++++
> 1 file changed, 33 insertions(+)
>


Hi Guido,

Tested-by: Martin Kepplinger <[email protected]>

thanks,
martin

2020-08-23 03:04:00

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH v2 2/4] arm64: dts: imx8mq-librem5-devkit: Enable the LCD panel

On Thu, Aug 20, 2020 at 10:50:57AM +0200, Guido G?nther wrote:
> Enable LCD panel output by adding nodes for the NWL DSI host controller,
> the Rocktech panel and the eLCDIF display controller.
>
> Signed-off-by: Guido G?nther <[email protected]>
> Reviewed-by: Fabio Estevam <[email protected]>

Applied, thanks.

2020-08-23 03:06:16

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH v2 3/4] arm64: defconfig: re-sync DRM related defconfig bits

On Thu, Aug 20, 2020 at 10:50:58AM +0200, Guido G?nther wrote:
> This moves the CONFIG_DRM_SIMPLE_BRIDGE entry around making further
> updates simpler.
>
> Signed-off-by: Guido G?nther <[email protected]>

Patch #3 and #4 do not apply to my branch.

Shawn

2020-08-23 07:28:41

by Guido Günther

[permalink] [raw]
Subject: Re: [PATCH v2 3/4] arm64: defconfig: re-sync DRM related defconfig bits

Hi,
On Sun, Aug 23, 2020 at 10:56:22AM +0800, Shawn Guo wrote:
> On Thu, Aug 20, 2020 at 10:50:58AM +0200, Guido G?nther wrote:
> > This moves the CONFIG_DRM_SIMPLE_BRIDGE entry around making further
> > updates simpler.
> >
> > Signed-off-by: Guido G?nther <[email protected]>
>
> Patch #3 and #4 do not apply to my branch.

Thanks for applying the other two already! I've rebased these against

https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/log/?h=imx/defconfig

in v4:

https://lore.kernel.org/linux-devicetree/[email protected]/T/#t

Cheers,
-- Guido


>
> Shawn
>