2020-08-29 01:16:29

by Ross Schmidt

[permalink] [raw]
Subject: [PATCH] Staging: rtl8723bs: os_dep: fixed some coding style issues

Fixed some coding style issues.

Signed-off-by: Ross Schmidt <[email protected]>
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index f1e2829a19a7..2b2f4505b98b 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -121,6 +121,7 @@ extern unsigned int oob_irq;
static irqreturn_t gpio_hostwakeup_irq_thread(int irq, void *data)
{
struct adapter *padapter = data;
+
DBG_871X_LEVEL(_drv_always_, "gpio_hostwakeup_irq_thread\n");
/* Disable interrupt before calling handler */
/* disable_irq_nosync(oob_irq); */
@@ -131,6 +132,7 @@ static irqreturn_t gpio_hostwakeup_irq_thread(int irq, void *data)
static u8 gpio_hostwakeup_alloc_irq(struct adapter *padapter)
{
int err;
+
if (oob_irq == 0) {
DBG_871X("oob_irq ZERO!\n");
return _FAIL;
--
2.26.2


2020-08-31 10:28:42

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] Staging: rtl8723bs: os_dep: fixed some coding style issues

On Fri, Aug 28, 2020 at 08:14:05PM -0500, Ross Schmidt wrote:
> Fixed some coding style issues.

What issues? Always be specific please.

Please fix up and resend.

thanks,

greg k-h