2020-09-11 02:04:04

by Jason Yan

Subject: [PATCH] MIPS: Make setup_elfcorehdr and setup_elfcorehdr_size static

This addresses the following sparse warning:

arch/mips/kernel/setup.c:446:33: warning: symbol 'setup_elfcorehdr_size'
was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
---
arch/mips/kernel/setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
index 335bd188b8b4..c004a311aaab 100644
--- a/arch/mips/kernel/setup.c
+++ b/arch/mips/kernel/setup.c
@@ -443,7 +443,7 @@ static int __init early_parse_memmap(char *p)
early_param("memmap", early_parse_memmap);

#ifdef CONFIG_PROC_VMCORE
-unsigned long setup_elfcorehdr, setup_elfcorehdr_size;
+static unsigned long setup_elfcorehdr, setup_elfcorehdr_size;
static int __init early_parse_elfcorehdr(char *p)
{
phys_addr_t start, end;
--
2.25.4

2020-09-21 21:01:09

by Thomas Bogendoerfer

Subject: Re: [PATCH] MIPS: Make setup_elfcorehdr and setup_elfcorehdr_size static

On Fri, Sep 11, 2020 at 10:01:32AM +0800, Jason Yan wrote:
> This addresses the following sparse warning:
>
> arch/mips/kernel/setup.c:446:33: warning: symbol 'setup_elfcorehdr_size'
> was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>
> ---
> arch/mips/kernel/setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]