2020-09-22 00:22:46

by Tomasz Figa

Subject: [PATCH] phy: rockchip-dphy-rx0: Include linux/delay.h

Fix an implicit declaration of usleep_range():

drivers/phy/rockchip/phy-rockchip-dphy-rx0.c: In function 'rk_dphy_enable':
drivers/phy/rockchip/phy-rockchip-dphy-rx0.c:203:2: error: implicit declaration of function 'usleep_range' [-Werror=implicit-function-declaration]

Fixes: 32abcc4491c62 ("media: staging: phy-rockchip-dphy-rx0: add Rockchip MIPI Synopsys DPHY RX0 driver")
Signed-off-by: Tomasz Figa <[email protected]>
---
drivers/phy/rockchip/phy-rockchip-dphy-rx0.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/phy/rockchip/phy-rockchip-dphy-rx0.c b/drivers/phy/rockchip/phy-rockchip-dphy-rx0.c
index 7c4df6d48c43..4df9476ef2a9 100644
--- a/drivers/phy/rockchip/phy-rockchip-dphy-rx0.c
+++ b/drivers/phy/rockchip/phy-rockchip-dphy-rx0.c
@@ -16,6 +16,7 @@
*/

#include <linux/clk.h>
+#include <linux/delay.h>
#include <linux/io.h>
#include <linux/mfd/syscon.h>
#include <linux/module.h>
--
2.28.0.681.g6f77f65b4e-goog

2020-09-22 08:33:42

by Heiko Stuebner

Subject: Re: [PATCH] phy: rockchip-dphy-rx0: Include linux/delay.h

Am Dienstag, 22. September 2020, 00:56:18 CEST schrieb Tomasz Figa:
> Fix an implicit declaration of usleep_range():
>
> drivers/phy/rockchip/phy-rockchip-dphy-rx0.c: In function 'rk_dphy_enable':
> drivers/phy/rockchip/phy-rockchip-dphy-rx0.c:203:2: error: implicit declaration of function 'usleep_range' [-Werror=implicit-function-declaration]
>
> Fixes: 32abcc4491c62 ("media: staging: phy-rockchip-dphy-rx0: add Rockchip MIPI Synopsys DPHY RX0 driver")
> Signed-off-by: Tomasz Figa <[email protected]>

Reviewed-by: Heiko Stuebner <[email protected]>

2020-09-22 14:18:21

by Vinod Koul

Subject: Re: [PATCH] phy: rockchip-dphy-rx0: Include linux/delay.h

On 21-09-20, 22:56, Tomasz Figa wrote:
> Fix an implicit declaration of usleep_range():
>
> drivers/phy/rockchip/phy-rockchip-dphy-rx0.c: In function 'rk_dphy_enable':
> drivers/phy/rockchip/phy-rockchip-dphy-rx0.c:203:2: error: implicit declaration of function 'usleep_range' [-Werror=implicit-function-declaration]

Applied, thanks

--
~Vinod