2020-10-10 08:54:56

by Iskren Chernev

[permalink] [raw]
Subject: [PATCH] power: supply: ltc2941: Fix ptr to enum cast

clang complains about casting pointers to smaller enum types.

Signed-off-by: Iskren Chernev <[email protected]>
---
drivers/power/supply/ltc2941-battery-gauge.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/power/supply/ltc2941-battery-gauge.c b/drivers/power/supply/ltc2941-battery-gauge.c
index 30a9014b2f95e..10cd617516ec2 100644
--- a/drivers/power/supply/ltc2941-battery-gauge.c
+++ b/drivers/power/supply/ltc2941-battery-gauge.c
@@ -473,7 +473,8 @@ static int ltc294x_i2c_probe(struct i2c_client *client,

np = of_node_get(client->dev.of_node);

- info->id = (enum ltc294x_id)of_device_get_match_data(&client->dev);
+ info->id = (enum ltc294x_id) (uintptr_t) of_device_get_match_data(
+ &client->dev);
info->supply_desc.name = np->name;

/* r_sense can be negative, when sense+ is connected to the battery

base-commit: 411643e949f4e616f758e2c6079f333b0e704c49
--
2.28.0


2020-10-11 18:00:15

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH] power: supply: ltc2941: Fix ptr to enum cast

Hi,

On Sat, Oct 10, 2020 at 09:55:26AM +0300, Iskren Chernev wrote:
> clang complains about casting pointers to smaller enum types.
>
> Signed-off-by: Iskren Chernev <[email protected]>
> ---

Thanks, queued.

-- Sebastian

> drivers/power/supply/ltc2941-battery-gauge.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/ltc2941-battery-gauge.c b/drivers/power/supply/ltc2941-battery-gauge.c
> index 30a9014b2f95e..10cd617516ec2 100644
> --- a/drivers/power/supply/ltc2941-battery-gauge.c
> +++ b/drivers/power/supply/ltc2941-battery-gauge.c
> @@ -473,7 +473,8 @@ static int ltc294x_i2c_probe(struct i2c_client *client,
>
> np = of_node_get(client->dev.of_node);
>
> - info->id = (enum ltc294x_id)of_device_get_match_data(&client->dev);
> + info->id = (enum ltc294x_id) (uintptr_t) of_device_get_match_data(
> + &client->dev);
> info->supply_desc.name = np->name;
>
> /* r_sense can be negative, when sense+ is connected to the battery
>
> base-commit: 411643e949f4e616f758e2c6079f333b0e704c49
> --
> 2.28.0
>


Attachments:
(No filename) (1.10 kB)
signature.asc (849.00 B)
Download all attachments