2020-10-12 02:16:16

by Clément Péron

[permalink] [raw]
Subject: [PATCH] dt-bindings: sound: sun8i-a33-codec: Add Allwinner A64 codec compatible fallback

make dtbs_check report a warning because the documentation
for the A64 codec compatible is missing.

The A64 codec compatible is actually a simple fallback to the A33.

Reflect this in the dt-bindings Documentation.

Signed-off-by: Clément Péron <[email protected]>
---
.../bindings/sound/allwinner,sun8i-a33-codec.yaml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml
index 55d28268d2f4..e78a22496e7c 100644
--- a/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml
+++ b/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml
@@ -15,7 +15,11 @@ properties:
const: 0

compatible:
- const: allwinner,sun8i-a33-codec
+ oneOf:
+ - const: allwinner,sun8i-a33-codec
+ - items:
+ - const: allwinner,sun50i-a64-codec
+ - const: allwinner,sun8i-a33-codec

reg:
maxItems: 1
--
2.25.1


2020-10-12 08:16:11

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: sound: sun8i-a33-codec: Add Allwinner A64 codec compatible fallback

Hi!

On Sun, Oct 11, 2020 at 11:15:42PM +0200, Cl?ment P?ron wrote:
> make dtbs_check report a warning because the documentation
> for the A64 codec compatible is missing.
>
> The A64 codec compatible is actually a simple fallback to the A33.
>
> Reflect this in the dt-bindings Documentation.
>
> Signed-off-by: Cl?ment P?ron <[email protected]>

This patch is already in the ASoC tree and linux-next:

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml?id=cef305d4eb0733f25215793ed30b056a7db9bb62

Maxime

Attachments:
(No filename) (623.00 B)
 signature.asc (235.00 B)
 Download all attachments

2020-10-12 08:39:33

by Clément Péron

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: sound: sun8i-a33-codec: Add Allwinner A64 codec compatible fallback

Hi Maxime and all,

On Mon, 12 Oct 2020 at 09:50, Maxime Ripard <[email protected]> wrote:
>
> Hi!
>
> On Sun, Oct 11, 2020 at 11:15:42PM +0200, Clément Péron wrote:
> > make dtbs_check report a warning because the documentation
> > for the A64 codec compatible is missing.
> >
> > The A64 codec compatible is actually a simple fallback to the A33.
> >
> > Reflect this in the dt-bindings Documentation.
> >
> > Signed-off-by: Clément Péron <[email protected]>
>
> This patch is already in the ASoC tree and linux-next:

I was indeed on top of sunxi/for-next and not linux-next/master

I will test on top of linux-next for the next ones.

Sorry for the duplicate patch and the noise :(.
Clement

>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml?id=cef305d4eb0733f25215793ed30b056a7db9bb62
>
> Maxime