2020-10-22 03:42:39

by Coiby Xu

Subject: [PATCH] HID: i2c-hid: show the error of failing to fetch the HID Descriptor

i2c_hid_probe should notify the user of the error of failing to fetch
the HID Descriptor instead of silently exiting.

Link: https://forum.manjaro.org/t/elan-touchpad-working-in-live-but-not-in-native-os/31860/55
Cc: Barnabás Pőcze <[email protected]>
Signed-off-by: Coiby Xu <[email protected]>
---
drivers/hid/i2c-hid/i2c-hid-core.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
index 786e3e9af1c9..577d324be16d 100644
--- a/drivers/hid/i2c-hid/i2c-hid-core.c
+++ b/drivers/hid/i2c-hid/i2c-hid-core.c
@@ -1099,8 +1099,11 @@ static int i2c_hid_probe(struct i2c_client *client,
}

ret = i2c_hid_fetch_hid_descriptor(ihid);
- if (ret < 0)
+ if (ret < 0) {
+ dev_err(&client->dev,
+ "Failed to fetch the HID Descriptor\n");
goto err_regulator;
+ }

ret = i2c_hid_init_irq(client);
if (ret < 0)
--
2.28.0

2020-10-29 15:13:56

by Jiri Kosina

Subject: Re: [PATCH] HID: i2c-hid: show the error of failing to fetch the HID Descriptor

On Wed, 21 Oct 2020, Coiby Xu wrote:

> i2c_hid_probe should notify the user of the error of failing to fetch
> the HID Descriptor instead of silently exiting.
>
> Link: https://forum.manjaro.org/t/elan-touchpad-working-in-live-but-not-in-native-os/31860/55
> Cc: Barnabás Pőcze <[email protected]>
> Signed-off-by: Coiby Xu <[email protected]>

Applied, thank you.

--
Jiri Kosina
SUSE Labs