2020-10-29 08:51:49

by Phil Auld

[permalink] [raw]
Subject: Re: [PATCH 0/8] Style and small fixes for core-scheduling

Hi John,

On Wed, Oct 28, 2020 at 05:19:09AM -0700 John B. Wyatt IV wrote:
> Patchset of style and small fixes for the 8th iteration of the
> Core-Scheduling feature.
>
> Style fixes include changing spaces to tabs, inserting new lines before
> declarations, removing unused braces, and spelling.
>
> Two small fixes involving changing a main() to main(void) and removing an
> unused 'else'.
>
> All issues were reported by checkpatch.
>
> I am a new Linux kernel developer interning with the Outreachy project.
>

Welcome!

> Please feel free to advise on any corrections or improvements that can be
> made.

Thanks for these. I wonder, though, if it would not make more sense
to post these changes as comments on the original as-yet-unmerged
patches that you are fixing up?


Cheers,
Phil

>
> John B. Wyatt IV (8):
> sched: Correct misspellings in core-scheduling.rst
> sched: Fix bad function definition
> sched: Fix some style issues in test_coresched.c
> sched: Remove unused else
> sched: Add newline after declaration
> sched: Remove unneeded braces
> sched: Replace spaces with tabs
> sched: Add newlines after declarations
>
> Documentation/admin-guide/hw-vuln/core-scheduling.rst | 8 ++++----
> arch/x86/include/asm/thread_info.h | 4 ++--
> kernel/sched/core.c | 6 ++++--
> kernel/sched/coretag.c | 3 ++-
> tools/testing/selftests/sched/test_coresched.c | 8 ++++----
> 5 files changed, 16 insertions(+), 13 deletions(-)
>
> --
> 2.28.0
>

--