2020-10-28 22:09:10

by Qinglang Miao

Subject: [PATCH] ARM: imx: add missing clk_disable_unprepare() when remove imx_mmdc

Clock source is prepared and enabled by clk_prepare_enable()
in probe function, but no disable or unprepare in remove.

Signed-off-by: Qinglang Miao <[email protected]>
---
arch/arm/mach-imx/mmdc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-imx/mmdc.c b/arch/arm/mach-imx/mmdc.c
index 0dfd0ae7a..56375e8da 100644
--- a/arch/arm/mach-imx/mmdc.c
+++ b/arch/arm/mach-imx/mmdc.c
@@ -462,6 +462,7 @@ static int imx_mmdc_remove(struct platform_device *pdev)

cpuhp_state_remove_instance_nocalls(cpuhp_mmdc_state, &pmu_mmdc->node);
perf_pmu_unregister(&pmu_mmdc->pmu);
+ clk_disable_unprepare(mmdc_ipg_clk);
kfree(pmu_mmdc);
return 0;
}
--
2.23.0

2020-11-01 09:26:10

by Shawn Guo

Subject: Re: [PATCH] ARM: imx: add missing clk_disable_unprepare() when remove imx_mmdc

On Wed, Oct 28, 2020 at 05:15:39PM +0800, Qinglang Miao wrote:
> Clock source is prepared and enabled by clk_prepare_enable()
> in probe function, but no disable or unprepare in remove.
>
> Signed-off-by: Qinglang Miao <[email protected]>

Applied, thanks.