2020-10-29 22:41:57

by Colin King

Subject: [PATCH] clk: imx: remove redundant assignment to pointer np

From: Colin Ian King <[email protected]>

Pointer np is being initialized with a value that is never read
and it is being updated with a value later on. The initialization
is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/clk/imx/clk-imx8mp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c
index 12ce4770f702..3cb2bc46eae0 100644
--- a/drivers/clk/imx/clk-imx8mp.c
+++ b/drivers/clk/imx/clk-imx8mp.c
@@ -425,7 +425,7 @@ static struct clk **uart_clks[ARRAY_SIZE(uart_clk_ids) + 1];
static int imx8mp_clocks_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
- struct device_node *np = dev->of_node;
+ struct device_node *np;
void __iomem *anatop_base, *ccm_base;
int i;

--
2.27.0

2020-10-30 03:29:03

by Aisheng Dong

Subject: RE: [PATCH] clk: imx: remove redundant assignment to pointer np

> From: Colin King <[email protected]>
> Sent: Friday, October 30, 2020 6:40 AM
>
> Pointer np is being initialized with a value that is never read and it is being
> updated with a value later on. The initialization is redundant and can be
> removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: Dong Aisheng <[email protected]>

Regards
Aisheng

2020-11-01 09:30:16

by Shawn Guo

Subject: Re: [PATCH] clk: imx: remove redundant assignment to pointer np

On Thu, Oct 29, 2020 at 10:40:07PM +0000, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Pointer np is being initialized with a value that is never read
> and it is being updated with a value later on. The initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Applied, thanks.