2020-10-21 12:38:37

by Dinghao Liu

Subject: [PATCH] btrfs: ref-verify: Fix memleak in btrfs_ref_tree_mod

There is one error handling path does not free ref,
which may cause a memory leak.

Signed-off-by: Dinghao Liu <[email protected]>
---
fs/btrfs/ref-verify.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/btrfs/ref-verify.c b/fs/btrfs/ref-verify.c
index 7f03dbe5b609..78693d3dd15b 100644
--- a/fs/btrfs/ref-verify.c
+++ b/fs/btrfs/ref-verify.c
@@ -860,6 +860,7 @@ int btrfs_ref_tree_mod(struct btrfs_fs_info *fs_info,
"dropping a ref for a root that doesn't have a ref on the block");
dump_block_entry(fs_info, be);
dump_ref_action(fs_info, ra);
+ kfree(ref);
kfree(ra);
goto out_unlock;
}
--
2.17.1

2020-11-05 11:54:46

by David Sterba

Subject: Re: [PATCH] btrfs: ref-verify: Fix memleak in btrfs_ref_tree_mod

On Wed, Oct 21, 2020 at 01:36:55PM +0800, Dinghao Liu wrote:
> There is one error handling path does not free ref,
> which may cause a memory leak.
>
> Signed-off-by: Dinghao Liu <[email protected]>

Added to misc-next, thanks.