2020-11-09 12:25:09

by Frank Lee

[permalink] [raw]

Subject: [PATCH] arm64: dts: allwinner: a64: fix sid node name

---

From: Yangtao Li <[email protected]>

Sid should be an efuse type device accurately. And no one
needs sid label, so delete it.

Signed-off-by: Yangtao Li <[email protected]>
---
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
index dc238814013c..96543df5d890 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
@@ -520,7 +520,7 @@ mmc2: mmc@1c11000 {
#size-cells = <0>;
};

- sid: eeprom@1c14000 {
+ efuse@1c14000 {
compatible = "allwinner,sun50i-a64-sid";
reg = <0x1c14000 0x400>;
#address-cells = <1>;
--
2.28.0

2020-11-12 09:56:23

by Maxime Ripard

[permalink] [raw]

Subject: Re: [PATCH] arm64: dts: allwinner: a64: fix sid node name

---

Hi,

On Mon, Nov 09, 2020 at 08:21:01PM +0800, Frank Lee wrote:
> From: Yangtao Li <[email protected]>
>
> Sid should be an efuse type device accurately. And no one
> needs sid label, so delete it.
>
> Signed-off-by: Yangtao Li <[email protected]>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index dc238814013c..96543df5d890 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -520,7 +520,7 @@ mmc2: mmc@1c11000 {
> #size-cells = <0>;
> };
>
> - sid: eeprom@1c14000 {
> + efuse@1c14000 {
> compatible = "allwinner,sun50i-a64-sid";
> reg = <0x1c14000 0x400>;
> #address-cells = <1>;

I agree with this on principle, but we should do it on all the SoCs at
once. Can you send another version doing so?

Thanks!
Maxime

---

Attachments:

(No filename) (1.01 kB)
signature.asc (235.00 B)
Download all attachments