2020-10-01 19:22:43

by Grygorii Strashko

[permalink] [raw]
Subject: [PATCH] ARM: dts: am437x-l4: fix compatible for cpsw switch dt node

Fix compatible the new CPSW switchdev DT node to avoid probing of legacy
CPSW driver which fails:
[ 2.781009] cpsw 4a100000.switch: invalid resource

Fixes: 7bf8f37aea82 ("ARM: dts: am437x-l4: add dt node for new cpsw switchdev driver")
Signed-off-by: Grygorii Strashko <[email protected]>
---
Hi Tony,

This is follow up patch for series [1], not critical.
[1] https://lore.kernel.org/patchwork/cover/1304085/

arch/arm/boot/dts/am437x-l4.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/am437x-l4.dtsi b/arch/arm/boot/dts/am437x-l4.dtsi
index d82a6eeaf1b3..3643e505e582 100644
--- a/arch/arm/boot/dts/am437x-l4.dtsi
+++ b/arch/arm/boot/dts/am437x-l4.dtsi
@@ -522,7 +522,7 @@
ranges = <0x0 0x100000 0x8000>;

mac_sw: switch@0 {
- compatible = "ti,am4372-cpsw","ti,cpsw-switch";
+ compatible = "ti,am4372-cpsw-switch", "ti,cpsw-switch";
reg = <0x0 0x4000>;
ranges = <0 0 0x4000>;
clocks = <&cpsw_125mhz_gclk>, <&dpll_clksel_mac_clk>;
--
2.17.1


2020-10-29 19:15:15

by Grygorii Strashko

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: am437x-l4: fix compatible for cpsw switch dt node

Hi Tony,

On 01/10/2020 22:20, Grygorii Strashko wrote:
> Fix compatible the new CPSW switchdev DT node to avoid probing of legacy
> CPSW driver which fails:
> [ 2.781009] cpsw 4a100000.switch: invalid resource
>
> Fixes: 7bf8f37aea82 ("ARM: dts: am437x-l4: add dt node for new cpsw switchdev driver")
> Signed-off-by: Grygorii Strashko <[email protected]>
> ---
> Hi Tony,
>
> This is follow up patch for series [1], not critical.
> [1] https://lore.kernel.org/patchwork/cover/1304085/

Could this be merged?

>
> arch/arm/boot/dts/am437x-l4.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/am437x-l4.dtsi b/arch/arm/boot/dts/am437x-l4.dtsi
> index d82a6eeaf1b3..3643e505e582 100644
> --- a/arch/arm/boot/dts/am437x-l4.dtsi
> +++ b/arch/arm/boot/dts/am437x-l4.dtsi
> @@ -522,7 +522,7 @@
> ranges = <0x0 0x100000 0x8000>;
>
> mac_sw: switch@0 {
> - compatible = "ti,am4372-cpsw","ti,cpsw-switch";
> + compatible = "ti,am4372-cpsw-switch", "ti,cpsw-switch";
> reg = <0x0 0x4000>;
> ranges = <0 0 0x4000>;
> clocks = <&cpsw_125mhz_gclk>, <&dpll_clksel_mac_clk>;
>

--
Best regards,
grygorii

2020-11-10 12:20:04

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: am437x-l4: fix compatible for cpsw switch dt node

* Grygorii Strashko <[email protected]> [201029 19:13]:
> Hi Tony,
>
> On 01/10/2020 22:20, Grygorii Strashko wrote:
> > Fix compatible the new CPSW switchdev DT node to avoid probing of legacy
> > CPSW driver which fails:
> > [ 2.781009] cpsw 4a100000.switch: invalid resource
> >
> > Fixes: 7bf8f37aea82 ("ARM: dts: am437x-l4: add dt node for new cpsw switchdev driver")
> > Signed-off-by: Grygorii Strashko <[email protected]>
> > ---
> > Hi Tony,
> >
> > This is follow up patch for series [1], not critical.
> > [1] https://lore.kernel.org/patchwork/cover/1304085/
>
> Could this be merged?

Sorry for the delay, applying into fixes.

Thanks,

Tony