2020-11-10 10:26:47

by Amelie Delaunay

Subject: [PATCH 1/2] phy: stm32: don't print an error on probe deferral

Change stm32-usbphyc driver to not print an error message when the device
probe operation is deferred.

Signed-off-by: Etienne Carriere <[email protected]>
Signed-off-by: Amelie Delaunay <[email protected]>
---
drivers/phy/st/phy-stm32-usbphyc.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
index 2b3639cba51a..fe3085eec201 100644
--- a/drivers/phy/st/phy-stm32-usbphyc.c
+++ b/drivers/phy/st/phy-stm32-usbphyc.c
@@ -328,11 +328,8 @@ static int stm32_usbphyc_probe(struct platform_device *pdev)
return PTR_ERR(usbphyc->base);

usbphyc->clk = devm_clk_get(dev, NULL);
- if (IS_ERR(usbphyc->clk)) {
- ret = PTR_ERR(usbphyc->clk);
- dev_err(dev, "clk get failed: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(usbphyc->clk))
+ dev_err_probe(dev, PTR_ERR(usbphyc->clk), "clk get_failed\n");

ret = clk_prepare_enable(usbphyc->clk);
if (ret) {
--
2.17.1

2020-11-16 07:40:02

by Vinod Koul

Subject: Re: [PATCH 1/2] phy: stm32: don't print an error on probe deferral

On 10-11-20, 11:23, Amelie Delaunay wrote:
> Change stm32-usbphyc driver to not print an error message when the device
> probe operation is deferred.

Applied all, thanks

--
~Vinod

2020-11-16 08:08:29

by Amelie Delaunay

Subject: Re: [PATCH 1/2] phy: stm32: don't print an error on probe deferral

Hi Vinod,

On 11/16/20 8:37 AM, Vinod Koul wrote:
> On 10-11-20, 11:23, Amelie Delaunay wrote:
>> Change stm32-usbphyc driver to not print an error message when the device
>> probe operation is deferred.
>
> Applied all, thanks
>

I'm sorry for the mess, I sent a v2 for the patch 1/2:
https://lore.kernel.org/patchwork/patch/1336206/
Indeed, I forgot the "return" before dev_err_probe.

Do you want me to send a fix?

Regards,
Amelie

2020-11-16 09:53:29

by Vinod Koul

Subject: Re: [PATCH 1/2] phy: stm32: don't print an error on probe deferral

On 16-11-20, 09:02, Amelie DELAUNAY wrote:
> Hi Vinod,
>
> On 11/16/20 8:37 AM, Vinod Koul wrote:
> > On 10-11-20, 11:23, Amelie Delaunay wrote:
> > > Change stm32-usbphyc driver to not print an error message when the device
> > > probe operation is deferred.
> >
> > Applied all, thanks
> >
>
> I'm sorry for the mess, I sent a v2 for the patch 1/2:
> https://lore.kernel.org/patchwork/patch/1336206/
> Indeed, I forgot the "return" before dev_err_probe.

No worries, I have dropped this and picked v2.
Do check if the patches are fine.

Thanks for letting me know

--
~Vinod

2020-11-16 10:23:36

by Amelie Delaunay

Subject: Re: [PATCH 1/2] phy: stm32: don't print an error on probe deferral

On 11/16/20 10:50 AM, Vinod Koul wrote:
> On 16-11-20, 09:02, Amelie DELAUNAY wrote:
>> Hi Vinod,
>>
>> On 11/16/20 8:37 AM, Vinod Koul wrote:
>>> On 10-11-20, 11:23, Amelie Delaunay wrote:
>>>> Change stm32-usbphyc driver to not print an error message when the device
>>>> probe operation is deferred.
>>>
>>> Applied all, thanks
>>>
>>
>> I'm sorry for the mess, I sent a v2 for the patch 1/2:
>> https://lore.kernel.org/patchwork/patch/1336206/
>> Indeed, I forgot the "return" before dev_err_probe.
>
> No worries, I have dropped this and picked v2.
> Do check if the patches are fine.
>
> Thanks for letting me know
>

All is fine now :) Thank you!