2020-11-17 10:50:03

by Olaf Hering

Subject: [PATCH v1] kbuild: enforce -Werror=unused-result

It is a hard error if a return value is ignored.
In case the return value has no meaning, remove the attribute.

Signed-off-by: Olaf Hering <[email protected]>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index e2c3f65c4721..c7f9acffad42 100644
--- a/Makefile
+++ b/Makefile
@@ -497,7 +497,7 @@ KBUILD_AFLAGS := -D__ASSEMBLY__ -fno-PIE
KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
-fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE \
-Werror=implicit-function-declaration -Werror=implicit-int \
- -Werror=return-type -Wno-format-security \
+ -Werror=return-type -Werror=unused-result -Wno-format-security \
-std=gnu89
KBUILD_CPPFLAGS := -D__KERNEL__
KBUILD_AFLAGS_KERNEL :=

2020-12-01 22:36:19

by Masahiro Yamada

Subject: Re: [PATCH v1] kbuild: enforce -Werror=unused-result

On Tue, Nov 17, 2020 at 7:47 PM Olaf Hering <[email protected]> wrote:
>
> It is a hard error if a return value is ignored.
> In case the return value has no meaning, remove the attribute.
>
> Signed-off-by: Olaf Hering <[email protected]>

Applied to linux-kbuild.
Thanks.


> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index e2c3f65c4721..c7f9acffad42 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -497,7 +497,7 @@ KBUILD_AFLAGS := -D__ASSEMBLY__ -fno-PIE
> KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
> -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE \
> -Werror=implicit-function-declaration -Werror=implicit-int \
> - -Werror=return-type -Wno-format-security \
> + -Werror=return-type -Werror=unused-result -Wno-format-security \
> -std=gnu89
> KBUILD_CPPFLAGS := -D__KERNEL__
> KBUILD_AFLAGS_KERNEL :=



--
Best Regards
Masahiro Yamada

2020-12-21 06:35:17

by Masahiro Yamada

Subject: Re: [PATCH v1] kbuild: enforce -Werror=unused-result

On Tue, Dec 1, 2020 at 7:42 PM Masahiro Yamada <[email protected]> wrote:
>
> On Tue, Nov 17, 2020 at 7:47 PM Olaf Hering <[email protected]> wrote:
> >
> > It is a hard error if a return value is ignored.
> > In case the return value has no meaning, remove the attribute.
> >
> > Signed-off-by: Olaf Hering <[email protected]>
>
> Applied to linux-kbuild.
> Thanks.

I will postpone this by the next MW.

Some instances of __must_check violation are still remaining,
which end up with build breakages.





>
> > ---
> > Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Makefile b/Makefile
> > index e2c3f65c4721..c7f9acffad42 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -497,7 +497,7 @@ KBUILD_AFLAGS := -D__ASSEMBLY__ -fno-PIE
> > KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
> > -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE \
> > -Werror=implicit-function-declaration -Werror=implicit-int \
> > - -Werror=return-type -Wno-format-security \
> > + -Werror=return-type -Werror=unused-result -Wno-format-security \
> > -std=gnu89
> > KBUILD_CPPFLAGS := -D__KERNEL__
> > KBUILD_AFLAGS_KERNEL :=
>
>
>
> --
> Best Regards
> Masahiro Yamada



--
Best Regards
Masahiro Yamada