2020-11-19 14:14:05

by Alexandru Ardelean

Subject: [PATCH] iio: accel: adis16201: remove unneeded spi_set_drvdata()

There is no matching spi_get_drvdata() in the driver. This looks like a
left-over from before the driver was converted to device-managed functions.

Signed-off-by: Alexandru Ardelean <[email protected]>
---
drivers/iio/accel/adis16201.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/iio/accel/adis16201.c b/drivers/iio/accel/adis16201.c
index f955cccb3e77..3633a4e302c6 100644
--- a/drivers/iio/accel/adis16201.c
+++ b/drivers/iio/accel/adis16201.c
@@ -268,7 +268,6 @@ static int adis16201_probe(struct spi_device *spi)
return -ENOMEM;

st = iio_priv(indio_dev);
- spi_set_drvdata(spi, indio_dev);

indio_dev->name = spi->dev.driver->name;
indio_dev->info = &adis16201_info;
--
2.17.1

2020-11-21 15:22:34

by Jonathan Cameron

Subject: Re: [PATCH] iio: accel: adis16201: remove unneeded spi_set_drvdata()

On Thu, 19 Nov 2020 16:17:29 +0200
Alexandru Ardelean <[email protected]> wrote:

> There is no matching spi_get_drvdata() in the driver. This looks like a
> left-over from before the driver was converted to device-managed functions.
>
> Signed-off-by: Alexandru Ardelean <[email protected]>
Applied.

Thanks,

Jonathan

> ---
> drivers/iio/accel/adis16201.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/accel/adis16201.c b/drivers/iio/accel/adis16201.c
> index f955cccb3e77..3633a4e302c6 100644
> --- a/drivers/iio/accel/adis16201.c
> +++ b/drivers/iio/accel/adis16201.c
> @@ -268,7 +268,6 @@ static int adis16201_probe(struct spi_device *spi)
> return -ENOMEM;
>
> st = iio_priv(indio_dev);
> - spi_set_drvdata(spi, indio_dev);
>
> indio_dev->name = spi->dev.driver->name;
> indio_dev->info = &adis16201_info;