2020-11-20 18:34:46

by Gustavo A. R. Silva

Subject: [PATCH 058/141] xen-blkfront: Fix fall-through warnings for Clang

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/block/xen-blkfront.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 48629d3433b4..34b028be78ab 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -2462,6 +2462,7 @@ static void blkback_changed(struct xenbus_device *dev,
break;
if (talk_to_blkback(dev, info))
break;
+ break;
case XenbusStateInitialising:
case XenbusStateInitialised:
case XenbusStateReconfiguring:
--
2.27.0

2020-11-20 21:41:53

by Boris Ostrovsky

Subject: Re: [PATCH 058/141] xen-blkfront: Fix fall-through warnings for Clang

On 11/20/20 1:32 PM, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/block/xen-blkfront.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 48629d3433b4..34b028be78ab 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -2462,6 +2462,7 @@ static void blkback_changed(struct xenbus_device *dev,
> break;
> if (talk_to_blkback(dev, info))
> break;
> + break;
> case XenbusStateInitialising:
> case XenbusStateInitialised:
> case XenbusStateReconfiguring:


Reviewed-by Boris Ostrovsky <[email protected]>


(for patch 138 as well)


Although I thought using 'fallthrough' attribute was the more common approach.


-boris

2020-11-23 22:59:20

by Gustavo A. R. Silva

Subject: Re: [PATCH 058/141] xen-blkfront: Fix fall-through warnings for Clang

On Fri, Nov 20, 2020 at 04:36:26PM -0500, [email protected] wrote:
>
> On 11/20/20 1:32 PM, Gustavo A. R. Silva wrote:
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> > by explicitly adding a break statement instead of letting the code fall
> > through to the next case.
> >
> > Link: https://github.com/KSPP/linux/issues/115
> > Signed-off-by: Gustavo A. R. Silva <[email protected]>
> > ---
> > drivers/block/xen-blkfront.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> > index 48629d3433b4..34b028be78ab 100644
> > --- a/drivers/block/xen-blkfront.c
> > +++ b/drivers/block/xen-blkfront.c
> > @@ -2462,6 +2462,7 @@ static void blkback_changed(struct xenbus_device *dev,
> > break;
> > if (talk_to_blkback(dev, info))
> > break;
> > + break;
> > case XenbusStateInitialising:
> > case XenbusStateInitialised:
> > case XenbusStateReconfiguring:
>
>
> Reviewed-by Boris Ostrovsky <[email protected]>
>
>
> (for patch 138 as well)

Thank you for both reviews, Boris.

> Although I thought using 'fallthrough' attribute was the more common approach.

I've got it. I will consider that for a future patch.

Thanks
--
Gustavo