2020-11-25 16:54:19

by FLAVIO SULIGOI

[permalink] [raw]
Subject: [PATCH v1] docs/vm: hwpoison: fix spelling mistakes

Actions:

- fix spelling mistake
- reduce some double spaces to a single one
- substitute spaces with tab

Signed-off-by: Flavio Suligoi <[email protected]>
---
Documentation/vm/hwpoison.rst | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/vm/hwpoison.rst b/Documentation/vm/hwpoison.rst
index a5c884293dac..88ba2df198d1 100644
--- a/Documentation/vm/hwpoison.rst
+++ b/Documentation/vm/hwpoison.rst
@@ -50,7 +50,7 @@ of applications. KVM support requires a recent qemu-kvm release.
For the KVM use there was need for a new signal type so that
KVM can inject the machine check into the guest with the proper
address. This in theory allows other applications to handle
-memory failures too. The expection is that near all applications
+memory failures too. The expectation is that near all applications
won't do that, but some very specialized ones might.

Failure recovery modes
@@ -121,7 +121,7 @@ Testing

unpoison-pfn
Software-unpoison page at PFN echoed into this file. This way
- a page can be reused again. This only works for Linux
+ a page can be reused again. This only works for Linux
injected failures, not for real memory failures.

Note these injection interfaces are not stable and might change between
@@ -129,8 +129,8 @@ Testing

corrupt-filter-dev-major, corrupt-filter-dev-minor
Only handle memory failures to pages associated with the file
- system defined by block device major/minor. -1U is the
- wildcard value. This should be only used for testing with
+ system defined by block device major/minor. -1U is the
+ wildcard value. This should be only used for testing with
artificial injection.

corrupt-filter-memcg
@@ -141,7 +141,7 @@ Testing

mkdir /sys/fs/cgroup/mem/hwpoison

- usemem -m 100 -s 1000 &
+ usemem -m 100 -s 1000 &
echo `jobs -p` > /sys/fs/cgroup/mem/hwpoison/tasks

memcg_ino=$(ls -id /sys/fs/cgroup/mem/hwpoison | cut -f1 -d' ')
@@ -152,7 +152,7 @@ Testing

corrupt-filter-flags-mask, corrupt-filter-flags-value
When specified, only poison pages if ((page_flags & mask) ==
- value). This allows stress testing of many kinds of
+ value). This allows stress testing of many kinds of
pages. The page_flags are the same as in /proc/kpageflags. The
flag bits are defined in include/linux/kernel-page-flags.h and
documented in Documentation/admin-guide/mm/pagemap.rst
--
2.25.1


2020-11-26 06:31:22

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH v1] docs/vm: hwpoison: fix spelling mistakes

On Wed, 25 Nov 2020 17:52:22 +0100
Flavio Suligoi <[email protected]> wrote:

> Actions:
>
> - fix spelling mistake
> - reduce some double spaces to a single one

Please don't make changes like that last one; double spaces are not an
error, and "fixing" them just adds noise to the history.

Thanks,

jon

2020-11-26 10:53:16

by FLAVIO SULIGOI

[permalink] [raw]
Subject: RE: [PATCH v1] docs/vm: hwpoison: fix spelling mistakes

Hi Jon,

[PATCH v1] docs/vm: hwpoison: fix spelling mistakes
>
> On Wed, 25 Nov 2020 17:52:22 +0100
> Flavio Suligoi <[email protected]> wrote:
>
> > Actions:
> >
> > - fix spelling mistake
> > - reduce some double spaces to a single one
>
> Please don't make changes like that last one; double spaces are not an
> error, and "fixing" them just adds noise to the history.

Thanks for your suggestions! I'm still learning!

>
> Thanks,
>
> jon

Best regards,

Flavio