2020-11-24 18:48:21

by Bjorn Andersson

Subject: [PATCH] arm64: dts: qcom: c630: Re-enable apps_smmu

Re-enable the apps_smmu now that the arm-smmu driver supports stream
mapping handoff from firmware.

Signed-off-by: Bjorn Andersson <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 5 -----
1 file changed, 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
index d03ca3190746..f5b98845fa90 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
@@ -232,11 +232,6 @@ vreg_lvs2a_1p8: lvs2 {
};
};

-&apps_smmu {
- /* TODO: Figure out how to survive booting with this enabled */
- status = "disabled";
-};
-
&cdsp_pas {
firmware-name = "qcom/LENOVO/81JL/qccdsp850.mbn";
status = "okay";
--
2.29.2

2020-11-30 05:54:00

by Shawn Guo

Subject: Re: [PATCH] arm64: dts: qcom: c630: Re-enable apps_smmu

On Tue, Nov 24, 2020 at 12:44:14PM -0600, Bjorn Andersson wrote:
> Re-enable the apps_smmu now that the arm-smmu driver supports stream
> mapping handoff from firmware.
>
> Signed-off-by: Bjorn Andersson <[email protected]>

Acked-by: Shawn Guo <[email protected]>

> ---
> arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index d03ca3190746..f5b98845fa90 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -232,11 +232,6 @@ vreg_lvs2a_1p8: lvs2 {
> };
> };
>
> -&apps_smmu {
> - /* TODO: Figure out how to survive booting with this enabled */
> - status = "disabled";
> -};
> -
> &cdsp_pas {
> firmware-name = "qcom/LENOVO/81JL/qccdsp850.mbn";
> status = "okay";
> --
> 2.29.2
>

2020-11-30 16:26:21

by Steev Klimaszewski

Subject: Re: [PATCH] arm64: dts: qcom: c630: Re-enable apps_smmu

On 11/24/20 12:44 PM, Bjorn Andersson wrote:
> Re-enable the apps_smmu now that the arm-smmu driver supports stream
> mapping handoff from firmware.
>
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index d03ca3190746..f5b98845fa90 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -232,11 +232,6 @@ vreg_lvs2a_1p8: lvs2 {
> };
> };
>
> -&apps_smmu {
> - /* TODO: Figure out how to survive booting with this enabled */
> - status = "disabled";
> -};
> -
> &cdsp_pas {
> firmware-name = "qcom/LENOVO/81JL/qccdsp850.mbn";
> status = "okay";

Tested-by: Steev Klimaszewski <[email protected]>