2020-12-01 12:13:19

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH v5 01/16] HSI: fix a kernel-doc markup

A function has a different name between their prototype
and its kernel-doc markup.

Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---
drivers/hsi/hsi_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hsi/hsi_core.c b/drivers/hsi/hsi_core.c
index 47f0208aa7c3..c3fb5beb846e 100644
--- a/drivers/hsi/hsi_core.c
+++ b/drivers/hsi/hsi_core.c
@@ -323,65 +323,65 @@ EXPORT_SYMBOL_GPL(hsi_add_clients_from_dt);
#endif

int hsi_remove_client(struct device *dev, void *data __maybe_unused)
{
device_unregister(dev);

return 0;
}
EXPORT_SYMBOL_GPL(hsi_remove_client);

static int hsi_remove_port(struct device *dev, void *data __maybe_unused)
{
device_for_each_child(dev, NULL, hsi_remove_client);
device_unregister(dev);

return 0;
}

static void hsi_controller_release(struct device *dev)
{
struct hsi_controller *hsi = to_hsi_controller(dev);

kfree(hsi->port);
kfree(hsi);
}

static void hsi_port_release(struct device *dev)
{
kfree(to_hsi_port(dev));
}

/**
- * hsi_unregister_port - Unregister an HSI port
+ * hsi_port_unregister_clients - Unregister an HSI port
* @port: The HSI port to unregister
*/
void hsi_port_unregister_clients(struct hsi_port *port)
{
device_for_each_child(&port->device, NULL, hsi_remove_client);
}
EXPORT_SYMBOL_GPL(hsi_port_unregister_clients);

/**
* hsi_unregister_controller - Unregister an HSI controller
* @hsi: The HSI controller to register
*/
void hsi_unregister_controller(struct hsi_controller *hsi)
{
device_for_each_child(&hsi->device, NULL, hsi_remove_port);
device_unregister(&hsi->device);
}
EXPORT_SYMBOL_GPL(hsi_unregister_controller);

/**
* hsi_register_controller - Register an HSI controller and its ports
* @hsi: The HSI controller to register
*
* Returns -errno on failure, 0 on success.
*/
int hsi_register_controller(struct hsi_controller *hsi)
{
unsigned int i;
int err;

err = device_add(&hsi->device);
if (err < 0)
--
2.28.0


2020-12-02 21:44:24

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH v5 01/16] HSI: fix a kernel-doc markup

Hi,

On Tue, Dec 01, 2020 at 01:08:54PM +0100, Mauro Carvalho Chehab wrote:
> A function has a different name between their prototype
> and its kernel-doc markup.
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> ---

Thanks, queued to HSI tree.

-- Sebastian

> [...]
> /**
> - * hsi_unregister_port - Unregister an HSI port
> + * hsi_port_unregister_clients - Unregister an HSI port
> * @port: The HSI port to unregister
> */
> void hsi_port_unregister_clients(struct hsi_port *port)
> {
> device_for_each_child(&port->device, NULL, hsi_remove_client);
> }
> EXPORT_SYMBOL_GPL(hsi_port_unregister_clients);
> [...]


Attachments:
(No filename) (675.00 B)
signature.asc (849.00 B)
Download all attachments