2020-12-09 09:30:56

by Zheng Yongjun

Subject: [PATCH net-next] net: dsa: simplify the return rtl8366_vlan_prepare()

Simplify the return expression.

Signed-off-by: Zheng Yongjun <[email protected]>
---
drivers/net/dsa/rtl8366.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/net/dsa/rtl8366.c b/drivers/net/dsa/rtl8366.c
index 307466b90489..83d481ef9273 100644
--- a/drivers/net/dsa/rtl8366.c
+++ b/drivers/net/dsa/rtl8366.c
@@ -384,7 +384,6 @@ int rtl8366_vlan_prepare(struct dsa_switch *ds, int port,
{
struct realtek_smi *smi = ds->priv;
u16 vid;
- int ret;

for (vid = vlan->vid_begin; vid < vlan->vid_end; vid++)
if (!smi->ops->is_vlan_valid(smi, vid))
@@ -397,11 +396,7 @@ int rtl8366_vlan_prepare(struct dsa_switch *ds, int port,
* FIXME: what's with this 4k business?
* Just rtl8366_enable_vlan() seems inconclusive.
*/
- ret = rtl8366_enable_vlan4k(smi, true);
- if (ret)
- return ret;
-
- return 0;
+ return rtl8366_enable_vlan4k(smi, true);
}
EXPORT_SYMBOL_GPL(rtl8366_vlan_prepare);

--
2.22.0

2020-12-09 10:36:18

by Vladimir Oltean

Subject: Re: [PATCH net-next] net: dsa: simplify the return rtl8366_vlan_prepare()

On Wed, Dec 09, 2020 at 05:26:21PM +0800, Zheng Yongjun wrote:
> Simplify the return expression.
>
> Signed-off-by: Zheng Yongjun <[email protected]>
> ---

Reviewed-by: Vladimir Oltean <[email protected]>

2020-12-09 17:25:36

by Florian Fainelli

Subject: Re: [PATCH net-next] net: dsa: simplify the return rtl8366_vlan_prepare()

On 12/9/20 1:26 AM, Zheng Yongjun wrote:
> Simplify the return expression.
>
> Signed-off-by: Zheng Yongjun <[email protected]>

Reviewed-by: Florian Fainelli <[email protected]>
--
Florian

2020-12-10 01:17:55

by David Miller

Subject: Re: [PATCH net-next] net: dsa: simplify the return rtl8366_vlan_prepare()

From: Zheng Yongjun <[email protected]>
Date: Wed, 9 Dec 2020 17:26:21 +0800

> Simplify the return expression.
>
> Signed-off-by: Zheng Yongjun <[email protected]>

Applied.