2020-12-18 10:35:11

by Martin Kepplinger

Subject: [PATCH 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description

Add the pinctrl description for the interrupt.

Signed-off-by: Martin Kepplinger <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index 55268fc0622e..a60df09d90f7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -459,6 +459,13 @@
>;
};

+ pinctrl_touch: touchgrp {
+ fsl,pins = <
+ /* TP_INT */
+ MX8MQ_IOMUXC_ENET_RD1_GPIO1_IO27 0x80
+ >;
+ };
+
pinctrl_typec: typecgrp {
fsl,pins = <
/* TYPEC_MUX_EN */
@@ -880,6 +887,8 @@
touchscreen@38 {
compatible = "edt,edt-ft5506";
reg = <0x38>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_touch>;
interrupt-parent = <&gpio1>;
interrupts = <27 IRQ_TYPE_EDGE_FALLING>;
touchscreen-size-x = <720>;
--
2.20.1

2020-12-19 12:23:41

by Krzysztof Kozlowski

Subject: Re: [PATCH 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description

On Fri, Dec 18, 2020 at 11:31:29AM +0100, Martin Kepplinger wrote:
> Add the pinctrl description for the interrupt.

Please describe why do you need to add it. From the patch contents I
easily see what you are doing. But neither the commit title nor the
message describe what you want to achieve (why are you doing it).

Best regards,
Krzysztof